r44521 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r44520‎ | r44521 | r44522 >
Date:03:14, 13 December 2008
Author:werdna
Status:ok
Tags:
Comment:
Remove broken and unnecessary access-control for efConfigureAjax(). It requires configure-all AND extensions-all just to have a row formatted.
Modified paths:
  • /trunk/extensions/Configure/Configure.func.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Configure/Configure.func.php
@@ -24,8 +24,6 @@
2525 $settings = ConfigurationSettings::singleton( CONF_SETTINGS_BOTH );
2626 if ( $settings->getSettingType( $setting ) != 'array' )
2727 return '<err#>';
28 - if ( in_array( $setting, $settings->getEditRestricted() ) && ( !$wgUser->isAllowed( 'configure-all' ) || !$wgUser->isAllowed( 'extensions-all' ) ) )
29 - return '<err#>';
3028
3129 wfLoadExtensionMessages( 'Configure' );
3230 $type = $settings->getArrayType( $setting );

Status & tagging log