r44496 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r44495‎ | r44496 | r44497 >
Date:11:19, 12 December 2008
Author:raymond
Status:ok
Tags:
Comment:
Some tweaks for Special:ResetPass
* Use a more appropriate message for 'Retype new password:'
* Add missing CSS IDs for table and rows
Modified paths:
  • /trunk/phase3/includes/specials/SpecialResetpass.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialResetpass.php
@@ -84,7 +84,7 @@
8585 if ( !$wgUser->isLoggedIn() ) {
8686 $rememberMe = '<tr>' .
8787 '<td></td>' .
88 - '<td>' .
 88+ '<td class="mw-input">' .
8989 Xml::checkLabel( wfMsg( 'remembermypassword' ),
9090 'wpRemember', 'wpRemember',
9191 $wgRequest->getCheck( 'wpRemember' ) ) .
@@ -97,8 +97,7 @@
9898 $submitMsg = 'resetpass-submit-loggedin';
9999 }
100100 $wgOut->addHTML(
101 - Xml::openElement( 'fieldset' ) .
102 - Xml::element( 'legend', null, wfMsg( 'resetpass_header' ) ) .
 101+ Xml::fieldset( wfMsg( 'resetpass_header' ) ) .
103102 Xml::openElement( 'form',
104103 array(
105104 'method' => 'post',
@@ -108,21 +107,21 @@
109108 Xml::hidden( 'wpName', $this->mUserName ) .
110109 Xml::hidden( 'returnto', $wgRequest->getVal( 'returnto' ) ) .
111110 wfMsgExt( 'resetpass_text', array( 'parse' ) ) .
112 - '<table>' .
 111+ Xml::openElement( 'table', array( 'id' => 'mw-resetpass-table' ) ) .
113112 $this->pretty( array(
114113 array( 'wpName', 'username', 'text', $this->mUserName ),
115114 array( 'wpPassword', $oldpassMsg, 'password', $this->mOldpass ),
116115 array( 'wpNewPassword', 'newpassword', 'password', '' ),
117 - array( 'wpRetype', 'yourpasswordagain', 'password', '' ),
 116+ array( 'wpRetype', 'retypenew', 'password', '' ),
118117 ) ) .
119118 $rememberMe .
120119 '<tr>' .
121120 '<td></td>' .
122 - '<td>' .
 121+ '<td class="mw-input">' .
123122 Xml::submitButton( wfMsg( $submitMsg ) ) .
124123 '</td>' .
125124 '</tr>' .
126 - '</table>' .
 125+ Xml::closeElement( 'table' ) .
127126 Xml::closeElement( 'form' ) .
128127 Xml::closeElement( 'fieldset' )
129128 );

Status & tagging log