r44479 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r44478‎ | r44479 | r44480 >
Date:23:44, 11 December 2008
Author:brion
Status:ok
Tags:
Comment:
Partial revert of r43762 "Fix bad XHTML"
In addition to closing the </form>, this change moved around some calls which resulted in fatal errors for various types of page view such as a path-based search. Restored the original order of operations.
Modified paths:
  • /trunk/extensions/CodeReview/CodeRevisionView.php (modified) (history)

Diff [purge]

Index: trunk/extensions/CodeReview/CodeRevisionView.php
@@ -6,18 +6,13 @@
77 function __construct( $repoName, $rev, $replyTarget=null ){
88 global $wgRequest;
99 parent::__construct();
10 - $this->mPreviewText = false;
1110 $this->mRepo = CodeRepository::newFromName( $repoName );
12 - # If repo is defined, fetch the revision
13 - $this->mRev = $this->mRepo ?
14 - $this->mRepo->getRevision( intval( $rev ) ) : null;
 11+ $this->mRev = $this->mRepo ? $this->mRepo->getRevision( intval( $rev ) ) : null;
 12+ $this->mPreviewText = false;
1513 # URL params...
16 - $this->mAddTags = $this->splitTags( $wgRequest->getText( 'wpTag' ) );
17 - $this->mRemoveTags = $this->splitTags( $wgRequest->getText( 'wpRemoveTag' ) );
 14+ $this->mAddTags = $wgRequest->getText( 'wpTag' );
 15+ $this->mRemoveTags =$wgRequest->getText( 'wpRemoveTag' );
1816 $this->mStatus = $wgRequest->getText('wpStatus');
19 - # Get status from URL; if not set, then try the SVN revision
20 - $this->mStatus = ($this->mStatus || !$this->mRev) ?
21 - $this->mStatus : $this->mRev->getStatus();
2217 $this->jumpToNext = $wgRequest->getCheck('wpSaveAndNext');
2318 $this->mReplyTarget = $replyTarget ?
2419 (int)$replyTarget : $wgRequest->getIntOrNull( 'wpParent' );
@@ -37,6 +32,8 @@
3833 $view->execute();
3934 return;
4035 }
 36+ $this->mAddTags = $this->splitTags( $this->mAddTags );
 37+ $this->mRemoveTags = $this->splitTags( $this->mRemoveTags );
4138 $this->mStatus = $this->mStatus ? $this->mStatus : $this->mRev->getStatus();
4239
4340 $redirectOnPost = $this->checkPostings();

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r43762Fix bad XHTMLaaron14:26, 20 November 2008

Status & tagging log