r44425 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r44424‎ | r44425 | r44426 >
Date:22:31, 10 December 2008
Author:brion
Status:ok
Tags:
Comment:
Follow-up to r44245, r44250 (comment field on Special:Import)
Label now clickable for comment field on the transwiki form as well as the upload form; gave them both distinctive IDs.
Modified paths:
  • /trunk/phase3/includes/specials/SpecialImport.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialImport.php
@@ -150,10 +150,11 @@
151151 </tr>
152152 <tr>
153153 <td class='mw-label'>" .
154 - Xml::label( wfMsg( 'import-comment' ), 'log-comment' ) .
 154+ Xml::label( wfMsg( 'import-comment' ), 'mw-import-comment' ) .
155155 "</td>
156156 <td class='mw-input'>" .
157 - Xml::input( 'log-comment', 50, '', array( 'id' => 'log-comment', 'type' => 'text' ) ) . ' ' .
 157+ Xml::input( 'log-comment', 50, '',
 158+ array( 'id' => 'mw-import-comment', 'type' => 'text' ) ) . ' ' .
158159 "</td>
159160 </tr>
160161 <tr>
@@ -216,10 +217,11 @@
217218 </tr>
218219 <tr>
219220 <td class='mw-label'>" .
220 - Xml::label( wfMsg( 'import-comment' ), 'comment' ) .
 221+ Xml::label( wfMsg( 'import-comment' ), 'mw-interwiki-comment' ) .
221222 "</td>
222223 <td class='mw-input'>" .
223 - Xml::input( 'log-comment', 50, '', array( 'type' => 'text' ) ) . ' ' .
 224+ Xml::input( 'log-comment', 50, '',
 225+ array( 'id' => 'mw-interwiki-comment', 'type' => 'text' ) ) . ' ' .
224226 "</td>
225227 </tr>
226228 <tr>

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r44245log comment for imports (bug #12728)ariel02:14, 5 December 2008
r44250XHTML fixaaron14:37, 5 December 2008

Status & tagging log