r44419 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r44418‎ | r44419 | r44420 >
Date:19:29, 10 December 2008
Author:yaron
Status:deferred
Tags:
Comment:
Fixed bug in setting of values - is this code even used?
Modified paths:
  • /trunk/extensions/SemanticForms/includes/SF_FormInputs.inc (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticForms/includes/SF_FormInputs.inc
@@ -519,13 +519,13 @@
520520 // can show up here either as an array or a string, depending on
521521 // whether it came from user input or a wiki page
522522 if (is_array($datetime)) {
523 - if (isset($datetime['hour'])) $hour = $cur_value['hour'];
524 - if (isset($datetime['minute'])) $minute = $cur_value['minute'];
525 - if (isset($datetime['second'])) $second = $cur_value['second'];
 523+ if (isset($datetime['hour'])) $hour = $datetime['hour'];
 524+ if (isset($datetime['minute'])) $minute = $datetime['minute'];
 525+ if (isset($datetime['second'])) $second = $datetime['second'];
526526 if (! $sfg24HourTime) {
527 - if (isset($datetime['ampm24h'])) $ampm24h = $cur_value['ampm24h'];
 527+ if (isset($datetime['ampm24h'])) $ampm24h = $datetime['ampm24h'];
528528 }
529 - if (isset($datetime['timezone'])) $timezone = $cur_value['timezone'];
 529+ if (isset($datetime['timezone'])) $timezone = $datetime['timezone'];
530530 } else {
531531 $actual_date = strtotime($datetime);
532532 if ($sfg24HourTime) {

Status & tagging log