r44394 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r44393‎ | r44394 | r44395 >
Date:14:12, 10 December 2008
Author:catrope
Status:ok
Tags:
Comment:
API: (bug 16581) Fix regression from r44015 ("Various minor cleanup") which changed Article::replaceSection() to treat $section=null as $section=0 rather than $section='' as it did before, causing a nasty API edit bug. When changing a function's behavior, please update the callers, and don't forget the API.
Modified paths:
  • /trunk/phase3/includes/api/ApiEditPage.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/api/ApiEditPage.php
——@@ -116,6 +116,8 @@
117117 $this->dieUsage("The section parameter must be set to an integer or 'new'", "invalidsection");
118118 $reqArr['wpSection'] = $params['section'];
119119 }
 120+ else
 121+ $reqArr['wpSection'] = '';
120122
121123 if($params['watch'])
122124 $watch = true;

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r44015*Remove getContent() side-effects...aaron14:29, 28 November 2008

Status & tagging log