r44391 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r44390‎ | r44391 | r44392 >
Date:11:31, 10 December 2008
Author:ialex
Status:ok
Tags:
Comment:
Fix some PHP erros:
* Undefined constant CONF_SETTINGS_EXTENSIONS
* Missing param 1 for WebConfiguration::getCurrent()
* Lot of undefined offsets
Modified paths:
  • /trunk/extensions/Configure/SpecialConfigure.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Configure/SpecialConfigure.php
@@ -23,10 +23,11 @@
2424 $settings = $this->importFromRequest();
2525
2626 ## Add extensions settings, so we don't lose them..
27 - $extSettings = ConfigurationSettings::singleton( CONF_SETTINGS_EXTENSIONS )->getAllSettings();
28 - $current = $wgConf->getCurrent();
 27+ $extSettings = ConfigurationSettings::singleton( CONF_SETTINGS_EXT )->getAllSettings();
 28+ $current = $wgConf->getCurrent( $this->mWiki );
2929 foreach( $extSettings as $name => $type ) {
30 - $settings[$name] = $current[$name];
 30+ if( isset( $current[$name] ) )
 31+ $settings[$name] = $current[$name];
3132 }
3233
3334 $settings = $this->removeDefaults( $settings );

Status & tagging log