r44390 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r44389‎ | r44390 | r44391 >
Date:08:26, 10 December 2008
Author:werdna
Status:deferred
Tags:
Comment:
Fix up r44384. I now understand what those lines are and what they do.
Modified paths:
  • /trunk/extensions/Configure/SpecialConfigure.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Configure/SpecialConfigure.php
@@ -19,12 +19,16 @@
2020 protected function doSubmit() {
2121 global $wgConf, $wgOut, $wgConfigureUpdateCacheEpoch, $wgUser, $wgRequest;
2222
23 - // These two lines left in and commented-out until I figure out what they're for.
24 - // They seem to break stuff :)
2523 $reason = $wgRequest->getText( 'wpReason' );
26 -// $current = $wgConf->getCurrent( $this->mWiki );
2724 $settings = $this->importFromRequest();
28 -// $settings += $current;
 25+
 26+ ## Add extensions settings, so we don't lose them..
 27+ $extSettings = ConfigurationSettings::singleton( CONF_SETTINGS_EXTENSIONS )->getAllSettings();
 28+ $current = $wgConf->getCurrent();
 29+ foreach( $extSettings as $name => $type ) {
 30+ $settings[$name] = $current[$name];
 31+ }
 32+
2933 $settings = $this->removeDefaults( $settings );
3034 if ( $wgConfigureUpdateCacheEpoch )
3135 $settings['wgCacheEpoch'] = max( $settings['wgCacheEpoch'], wfTimestampNow() );

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r44384Fix up unnecessary display of some settings as 'changed' when they haven't be...werdna05:29, 10 December 2008

Status & tagging log