r44373 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r44372‎ | r44373 | r44374 >
Date:01:29, 10 December 2008
Author:werdna
Status:ok
Tags:
Comment:
Configure extension: Don't show settings which are marked as invalid for this version of MediaWiki.
Modified paths:
  • /trunk/extensions/Configure/Configure.page.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Configure/Configure.page.php
@@ -1249,10 +1249,8 @@
12501250
12511251 ## Only the class is customised per-cell, so we'll just redefine that.
12521252 $attribs['class'] = 'configure-right-column';
1253 - if ( $this->isSettingAvailable( $conf ) )
1254 - $td2 = Xml::tags( 'td', $attribs, $this->buildInput( $conf, $params ) );
1255 - else
1256 - $td2 = Xml::tags( 'td', $attribs, wfMsgExt( 'configure-setting-not-available', array( 'parseinline' ) ) );
 1253+
 1254+ $td2 = Xml::tags( 'td', $attribs, $this->buildInput( $conf, $params ) );
12571255
12581256 return Xml::tags( 'tr', array( 'class' => implode( ' ', $rowClasses ) ), $td1 . $td2 ) . "\n";
12591257 }
@@ -1332,6 +1330,8 @@
13331331 $show = $this->mCanEdit ?
13341332 ( isset( $params['edit'] ) ? $params['edit'] : $this->userCanEdit( $setting ) ) :
13351333 ( isset( $params['read'] ) ? $params['read'] : $this->userCanRead( $setting ) );
 1334+
 1335+ $show = $show && $this->isSettingAvailable( $setting );
13361336 if ( $show ) {
13371337 $thisGroup .= $this->buildTableRow( $setting, $params );
13381338 } else {

Status & tagging log