r44370 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r44369‎ | r44370 | r44371 >
Date:23:20, 9 December 2008
Author:vyznev
Status:ok
Tags:
Comment:
(bug 14365) skip invalid titles in RepoGroup::findFiles()
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/filerepo/RepoGroup.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/filerepo/RepoGroup.php
@@ -91,7 +91,8 @@
9292 foreach ( $titles as $title ) {
9393 if ( !( $title instanceof Title ) )
9494 $title = Title::makeTitleSafe( NS_FILE, $title );
95 - $titleObjs[$title->getDBkey()] = $title;
 95+ if ( $title )
 96+ $titleObjs[$title->getDBkey()] = $title;
9697 }
9798
9899 $images = $this->localRepo->findFiles( $titleObjs, $flags );
Index: trunk/phase3/RELEASE-NOTES
@@ -392,6 +392,8 @@
393393 * (bug 16577) When a blocked user tries to rollback a page, the block message
394394 is now only displayed once
395395 * (bug 14268) SVG image sizes now extracted with proper XML parser
 396+* (bug 14365) RepoGroup::findFiles() no longer crashes if passed an invalid
 397+ title via the API
396398
397399 === API changes in 1.14 ===
398400

Follow-up revisions

RevisionCommit summaryAuthorDate
r45387Add special case handling of the XHTML character entity "'" to normalize...vyznev02:29, 4 January 2009
r45477Revert r45387 "Add special case handling of the XHTML character entity "&apos...brion02:31, 7 January 2009

Status & tagging log