r44284 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r44283‎ | r44284 | r44285 >
Date:19:56, 7 December 2008
Author:ialex
Status:ok
Tags:
Comment:
Fix doxygen warnings
Modified paths:
  • /trunk/phase3/includes/LogEventsList.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/LogEventsList.php
@@ -47,7 +47,7 @@
4848
4949 /**
5050 * Set page title and show header for this log type
51 - * @param string $type
 51+ * @param $type String
5252 */
5353 public function showHeader( $type ) {
5454 if( LogPage::isLogType( $type ) ) {
@@ -58,13 +58,13 @@
5959
6060 /**
6161 * Show options for the log list
62 - * @param string $type,
63 - * @param string $user,
64 - * @param string $page,
65 - * @param string $pattern
66 - * @param int $year year
67 - * @param int $month month
68 - * @param bool $filter
 62+ * @param $type String
 63+ * @param $user String
 64+ * @param $page String
 65+ * @param $pattern String
 66+ * @param $year Integer: year
 67+ * @param $month Integer: month
 68+ * @param $filter Boolean
6969 */
7070 public function showOptions( $type = '', $user = '', $page = '', $pattern = '', $year = '',
7171 $month = '', $filter = null )
@@ -120,8 +120,8 @@
121121 }
122122
123123 /**
124 - * @return string Formatted HTML
125 - * @param string $queryType
 124+ * @param $queryType String
 125+ * @return String: Formatted HTML
126126 */
127127 private function getTypeMenu( $queryType ) {
128128 global $wgLogRestrictions, $wgUser;
@@ -158,25 +158,25 @@
159159 }
160160
161161 /**
162 - * @return string Formatted HTML
163 - * @param string $user
 162+ * @param $user String
 163+ * @return String: Formatted HTML
164164 */
165165 private function getUserInput( $user ) {
166166 return Xml::inputLabel( wfMsg( 'specialloguserlabel' ), 'user', 'user', 15, $user );
167167 }
168168
169169 /**
170 - * @return string Formatted HTML
171 - * @param string $title
 170+ * @param $title String
 171+ * @return String: Formatted HTML
172172 */
173173 private function getTitleInput( $title ) {
174174 return Xml::inputLabel( wfMsg( 'speciallogtitlelabel' ), 'page', 'page', 20, $title );
175175 }
176176
177177 /**
 178+ * @param $year Integer
 179+ * @param $month Integer
178180 * @return string Formatted HTML
179 - * @param int $year
180 - * @param int $month
181181 */
182182 private function getDateMenu( $year, $month ) {
183183 # Offset overrides year/month selection
@@ -221,10 +221,9 @@
222222 return "</ul>\n";
223223 }
224224
225 - /**
226 - * @param Row $row a single row from the result set
227 - * @return string Formatted HTML list item
228 - * @private
 225+ /**
 226+ * @param $row Row: a single row from the result set
 227+ * @return String: Formatted HTML list item
229228 */
230229 public function logLine( $row ) {
231230 global $wgLang, $wgUser, $wgContLang;
@@ -343,7 +342,7 @@
344343 }
345344
346345 /**
347 - * @param Row $row
 346+ * @param $row Row
348347 * @return string
349348 */
350349 private function getShowHideLinks( $row ) {
@@ -366,9 +365,9 @@
367366 }
368367
369368 /**
370 - * @param Row $row
371 - * @param mixed $type (string/array)
372 - * @param mixed $action (string/array)
 369+ * @param $row Row
 370+ * @param $type Mixed: string/array
 371+ * @param $action Mixed: string/array
373372 * @return bool
374373 */
375374 public static function typeAction( $row, $type, $action ) {
@@ -382,9 +381,9 @@
383382 /**
384383 * Determine if the current user is allowed to view a particular
385384 * field of this log row, if it's marked as deleted.
386 - * @param Row $row
387 - * @param int $field
388 - * @return bool
 385+ * @param $row Row
 386+ * @param $field Integer
 387+ * @return Boolean
389388 */
390389 public static function userCan( $row, $field ) {
391390 if( ( $row->log_deleted & $field ) == $field ) {
@@ -400,9 +399,9 @@
401400 }
402401
403402 /**
404 - * @param Row $row
405 - * @param int $field one of DELETED_* bitfield constants
406 - * @return bool
 403+ * @param $row Row
 404+ * @param $field Integer: one of DELETED_* bitfield constants
 405+ * @return Boolean
407406 */
408407 public static function isDeleted( $row, $field ) {
409408 return ($row->log_deleted & $field) == $field;
@@ -410,12 +409,12 @@
411410
412411 /**
413412 * Quick function to show a short log extract
414 - * @param OutputPage $out
415 - * @param string $type
416 - * @param string $page
417 - * @param string $user
418 - * @param int $lim
419 - * @param array $conds
 413+ * @param $out OutputPage
 414+ * @param $type String
 415+ * @param $page String
 416+ * @param $user String
 417+ * @param $lim Integer
 418+ * @param $conds Array
420419 */
421420 public static function showLogExtract( $out, $type='', $page='', $user='', $lim=0, $conds=array() ) {
422421 global $wgUser;
@@ -436,10 +435,10 @@
437436 return $pager->getNumRows();
438437 }
439438
440 - /**
 439+ /**
441440 * SQL clause to skip forbidden log types for this user
442 - * @param Database $db
443 - * @returns mixed (string or false)
 441+ * @param $db Database
 442+ * @return mixed (string or false)
444443 */
445444 public static function getExcludeClause( $db ) {
446445 global $wgLogRestrictions, $wgUser;
@@ -467,15 +466,18 @@
468467 class LogPager extends ReverseChronologicalPager {
469468 private $type = '', $user = '', $title = '', $pattern = '';
470469 public $mLogEventsList;
 470+
471471 /**
472 - * constructor
473 - * @param LogEventsList $loglist,
474 - * @param string $type,
475 - * @param string $user,
476 - * @param string $page,
477 - * @param string $pattern
478 - * @param array $conds
479 - */
 472+ * constructor
 473+ * @param $list LogEventsList
 474+ * @param $type String
 475+ * @param $user String
 476+ * @param $title String
 477+ * @param $pattern String
 478+ * @param $conds Array
 479+ * @param $year Integer
 480+ * @param $month Integer
 481+ */
480482 function __construct( $list, $type = '', $user = '', $title = '', $pattern = '',
481483 $conds = array(), $year = false, $month = false )
482484 {
@@ -519,8 +521,7 @@
520522 /**
521523 * Set the log reader to return only entries of the given type.
522524 * Type restrictions enforced here
523 - * @param string $type A log type ('upload', 'delete', etc)
524 - * @private
 525+ * @param $type String: A log type ('upload', 'delete', etc)
525526 */
526527 private function limitType( $type ) {
527528 global $wgLogRestrictions, $wgUser;
@@ -542,8 +543,7 @@
543544
544545 /**
545546 * Set the log reader to return only entries by the given user.
546 - * @param string $name (In)valid user name
547 - * @private
 547+ * @param $name String: (In)valid user name
548548 */
549549 private function limitUser( $name ) {
550550 if( $name == '' ) {
@@ -568,8 +568,8 @@
569569 /**
570570 * Set the log reader to return only entries affecting the given page.
571571 * (For the block and rights logs, this is a user page.)
572 - * @param string $page Title name as text
573 - * @private
 572+ * @param $page String: Title name as text
 573+ * @param $pattern String
574574 */
575575 private function limitTitle( $page, $pattern ) {
576576 global $wgMiserMode;
@@ -679,7 +679,7 @@
680680 class LogReader {
681681 var $pager;
682682 /**
683 - * @param WebRequest $request For internal use use a FauxRequest object to pass arbitrary parameters.
 683+ * @param $request WebRequest: for internal use use a FauxRequest object to pass arbitrary parameters.
684684 */
685685 function __construct( $request ) {
686686 global $wgUser, $wgOut;
@@ -716,13 +716,15 @@
717717 */
718718 class LogViewer {
719719 const NO_ACTION_LINK = 1;
 720+
720721 /**
721 - * @var LogReader $reader
 722+ * LogReader object
722723 */
723724 var $reader;
 725+
724726 /**
725 - * @param LogReader &$reader where to get our data from
726 - * @param integer $flags Bitwise combination of flags:
 727+ * @param &$reader LogReader: where to get our data from
 728+ * @param $flags Integer: Bitwise combination of flags:
727729 * LogEventsList::NO_ACTION_LINK Don't show restore/unblock/block links
728730 */
729731 function __construct( &$reader, $flags = 0 ) {
@@ -762,7 +764,7 @@
763765 * Output just the list of entries given by the linked LogReader,
764766 * with extraneous UI elements. Use for displaying log fragments in
765767 * another page (eg at Special:Undelete)
766 - * @param OutputPage $out where to send output
 768+ * @param $out OutputPage: where to send output
767769 */
768770 public function showList( &$out ) {
769771 $logBody = $this->pager->getBody();

Status & tagging log