r44261 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r44260‎ | r44261 | r44262 >
Date:20:27, 5 December 2008
Author:ialex
Status:ok
Tags:
Comment:
* Fixed E_NOTICE introduced in r44230
* Readd messages without link if the current wiki isn't in the version but the user can see foreign wikis, otherwise there will only be "(otherwiki)"
Modified paths:
  • /trunk/extensions/Configure/CHANGELOG (modified) (history)
  • /trunk/extensions/Configure/Configure.php (modified) (history)
  • /trunk/extensions/Configure/SpecialViewConfig.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Configure/SpecialViewConfig.php
@@ -193,8 +193,11 @@
194194 }
195195
196196 $actions = array();
 197+ $view = '';
197198 if ( $hasSelf )
198 - $view = $skin->makeKnownLinkObj( $self, wfMsgHtml( 'configure-view' ), "version=$ts" );
 199+ $view .= $skin->makeKnownLinkObj( $self, wfMsgHtml( 'configure-view' ), "version=$ts" );
 200+ elseif( $allowedAll )
 201+ $view .= wfMsgHtml( 'configure-view' );
199202
200203 if ( $allowedAll ) {
201204 $viewWikis = array();
@@ -203,11 +206,16 @@
204207 }
205208 $view .= ' (' . implode( ', ', $viewWikis ) . ')';
206209 }
207 - $actions[] = $view;
 210+
 211+ if( $view )
 212+ $actions[] = $view;
 213+
208214 $editDone = false;
209215 if ( $allowedConfig ) {
210216 if ( $hasSelf )
211217 $editCore = $editMsg . $skin->makeKnownLinkObj( $configTitle, wfMsgHtml( 'configure-edit-core' ), "version=$ts" );
 218+ elseif( $allowedConfigAll )
 219+ $editCore = $editMsg . wfMsgHtml( 'configure-edit-core' );
212220 else
213221 $editCore = $editMsg;
214222
@@ -226,6 +234,8 @@
227235 $editExt .= $editMsg;
228236 if ( $hasSelf )
229237 $editExt .= $skin->makeKnownLinkObj( $extTitle, wfMsgHtml( 'configure-edit-ext' ), "version=$ts" );
 238+ elseif( $allowedExtensionsAll )
 239+ $editExt .= wfMsgHtml( 'configure-edit-ext' );
230240
231241 if ( $allowedExtensionsAll ) {
232242 $viewWikis = array();
Index: trunk/extensions/Configure/CHANGELOG
@@ -1,6 +1,9 @@
22 This file lists changes on this extension.
33 Localisation updates are done on betawiki and aren't listed here.
44
 5+0.10.15 - 5 December 2008
 6+ Fixed PHP notices on Special:ViewConfig.
 7+
58 0.10.14 - 4 December 2008
69 * Added support for $wgRateLimits
710 * Don't show [+] for sections in TOC with only one subsection
Index: trunk/extensions/Configure/Configure.php
@@ -17,7 +17,7 @@
1818 'url' => 'http://www.mediawiki.org/wiki/Extension:Configure',
1919 'description' => 'Allow authorised users to configure the wiki via a web-based interface',
2020 'descriptionmsg' => 'configure-desc',
21 - 'version' => '0.10.14',
 21+ 'version' => '0.10.15',
2222 );
2323
2424 # Configuration part

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r44230Fix wgRateLimits display in read-only mode.werdna13:46, 4 December 2008

Status & tagging log