r44216 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r44215‎ | r44216 | r44217 >
Date:01:58, 4 December 2008
Author:demon
Status:ok (Comments)
Tags:
Comment:
Followup to r44204. Hardcoding image because it should (in theory) work always and forever. If you have a wiki acting as repo and you've overridden the canonical name Image: it's your own fault.
Modified paths:
  • /trunk/phase3/includes/filerepo/FileRepo.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/filerepo/FileRepo.php
——@@ -262,10 +262,10 @@
263263 if ( is_null( $this->descBaseUrl ) ) {
264264 if ( !is_null( $this->articleUrl ) ) {
265265 $this->descBaseUrl = str_replace( '$1',
266 - wfUrlencode( MWNamespace::getCanonicalName( NS_FILE ) ) . ':', $this->articleUrl );
 266+ wfUrlencode( 'Image:', $this->articleUrl );
267267 } elseif ( !is_null( $this->scriptDirUrl ) ) {
268268 $this->descBaseUrl = $this->scriptDirUrl . '/index.php?title=' .
269 - wfUrlencode( MWNamespace::getCanonicalName( NS_FILE ) ) . ':';
 269+ wfUrlencode( 'Image:';
270270 } else {
271271 $this->descBaseUrl = false;
272272 }

Follow-up revisions

RevisionCommit summaryAuthorDate
r44424Follow-up to r44216/r44217 "Followup to r44204. Hardcoding image because it s...brion22:07, 10 December 2008

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r44204Revert r44185, r44186 -- "Foreign repos (API or DB) now fetch images and/or d...brion23:49, 3 December 2008

Comments

#Comment by Brion VIBBER (talk | contribs)   21:42, 10 December 2008

yay!

Status & tagging log