r44214 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r44213‎ | r44214 | r44215 >
Date:01:39, 4 December 2008
Author:yaron
Status:deferred
Tags:
Comment:
Type checking for SMW 1.3 and earlier
Modified paths:
  • /trunk/extensions/SemanticDrilldown/includes/SD_GlobalFunctions.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticDrilldown/includes/SD_GlobalFunctions.php
@@ -316,7 +316,7 @@
317317 // make sure alias doesn't match actual property name - this
318318 // is an issue for English, since the English-language values
319319 // are used for aliases
320 - if ($alias != $property && $cur_prop == $prop) {
 320+ if (($alias != $property) && (! $prop instanceof Title) && ($cur_prop == $prop)) {
321321 $prop = sdfCreateProperty($alias, SMW_NS_PROPERTY);
322322 $prop_vals = $store->getPropertyValues($subject_title, $prop);
323323 foreach ($prop_vals as $prop_val) {

Status & tagging log