r44188 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r44187‎ | r44188 | r44189 >
Date:20:02, 3 December 2008
Author:yaron
Status:deferred
Tags:
Comment:
Reverted last change - messes up "unique number" feature
Modified paths:
  • /trunk/extensions/SemanticForms/includes/SF_FormPrinter.inc (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticForms/includes/SF_FormPrinter.inc
@@ -632,10 +632,8 @@
633633 // form values, see if the current input is part of that formula,
634634 // and if so, substitute in the actual value
635635 if ($form_submitted && $generated_page_name != '') {
636 - $generated_page_name = str_replace('.', '_', $generated_page_name);
637 - $generated_page_name = str_replace(' ', '_', $generated_page_name);
638 - $generated_page_name = str_ireplace("<$input_name>", $cur_value_in_template, $generated_page_name);
639 -
 636+ $true_input_name = str_replace('_', ' ', $input_name);
 637+ $generated_page_name = str_ireplace("<$true_input_name>", $cur_value_in_template, $generated_page_name);
640638 }
641639 // disable this field if either the whole form is disabled, or
642640 // it's a restricted field and user doesn't have sysop privileges

Status & tagging log