r44179 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r44178‎ | r44179 | r44180 >
Date:16:29, 3 December 2008
Author:ialex
Status:ok
Tags:
Comment:
Fixes for Special:ViewConfig:
* Fix JS bug in Configure.js line 414: arrayfield is null
* Also show the search box in that page
Modified paths:
  • /trunk/extensions/Configure/CHANGELOG (modified) (history)
  • /trunk/extensions/Configure/Configure.js (modified) (history)
  • /trunk/extensions/Configure/SpecialViewConfig.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Configure/SpecialViewConfig.php
@@ -99,6 +99,7 @@
100100 $this->showDiff();
101101 } else {
102102 $wgOut->addHTML(
 103+ $this->buildSearchForm() . "\n" .
103104 Xml::openElement( 'div', array( 'id' => 'configure-form' ) ) . "\n" .
104105 Xml::openElement( 'div', array( 'id' => 'configure' ) ) . "\n" .
105106
Index: trunk/extensions/Configure/CHANGELOG
@@ -2,7 +2,8 @@
33 Localisation updates are done on betawiki and aren't listed here.
44
55 0.10.13 - 3 December 2008
6 - * JavaScript-based setting search in Special:Configure and Special:Extensions
 6+ * JavaScript-based setting search in Special:Configure, Special:Extensions
 7+ and Special:ViewConfig
78 * Hidden settings now have a summary
89
910 0.10.12 - 2 December 2008
Index: trunk/extensions/Configure/Configure.js
@@ -411,7 +411,7 @@
412412 var label = labels[i];
413413 var arrayfield = document.getElementById( label.htmlFor );
414414
415 - if (arrayfield.value) {
 415+ if ( arrayfield && arrayfield.value ) {
416416 rows = true;
417417
418418 tr = document.createElement( 'tr' );

Status & tagging log