r44132 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r44131‎ | r44132 | r44133 >
Date:22:19, 1 December 2008
Author:aaron
Status:ok
Tags:
Comment:
Update comments, assuming this is cached
Modified paths:
  • /trunk/extensions/Configure/Configure.handler-db.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Configure/Configure.handler-db.php
@@ -89,7 +89,6 @@
9090 /**
9191 * Load the current configuration the database (i.e. cv_is_latest == 1)
9292 * directory
93 - * FIXME: serious O(n) overhead
9493 */
9594 public function getCurrent( $useCache = true ) {
9695 static $ipCached = null;
@@ -99,6 +98,7 @@
10099
101100 # Check filesystem cache
102101 if ( $useCache && ( $cached = $this->getFSCached() ) ) {
 102+ # FIXME: why does this always recache?
103103 $this->cacheToFS( $cached );
104104 return $ipCached = $cached;
105105 }
@@ -135,7 +135,7 @@
136136 /**
137137 * Return the old configuration from $ts
138138 * Does *not* return site specific settings but *all* settings
139 - * FIXME: serious O(n) overhead
 139+ * FIXME: timestamp is not unique
140140 *
141141 * @param $ts timestamp
142142 * @return array

Status & tagging log