r44041 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r44040‎ | r44041 | r44042 >
Date:17:43, 29 November 2008
Author:aaron
Status:ok
Tags:
Comment:
(bug 16480) Do not hide #mw-commentbox
Modified paths:
  • /trunk/extensions/FlaggedRevs/FlaggedRevs.php (modified) (history)
  • /trunk/extensions/FlaggedRevs/flaggedrevs.js (modified) (history)
  • /trunk/extensions/FlaggedRevs/language/FlaggedRevs.i18n.php (modified) (history)

Diff [purge]

Index: trunk/extensions/FlaggedRevs/FlaggedRevs.php
@@ -261,7 +261,7 @@
262262 #########
263263
264264 # Bump this number every time you change flaggedrevs.css/flaggedrevs.js
265 -$wgFlaggedRevStyleVersion = 44;
 265+$wgFlaggedRevStyleVersion = 45;
266266
267267 $wgExtensionFunctions[] = 'efLoadFlaggedRevs';
268268
Index: trunk/extensions/FlaggedRevs/language/FlaggedRevs.i18n.php
@@ -131,7 +131,7 @@
132132 'revreview-style-2' => 'Good',
133133 'revreview-style-3' => 'Concise',
134134 'revreview-style-4' => 'Featured',
135 - 'revreview-submit' => 'Submit review',
 135+ 'revreview-submit' => 'Submit',
136136 'revreview-submitting' => 'Submitting...',
137137 'revreview-finished' => 'Review complete!',
138138 'revreview-successful' => '\'\'\'Revision of [[:$1|$1]] successfully flagged. ([{{fullurl:Special:Stableversions|page=$2}} view stable versions])\'\'\'',
Index: trunk/extensions/FlaggedRevs/flaggedrevs.js
@@ -75,12 +75,6 @@
7676 somezero = true;
7777 }
7878 }
79 - showComment = (quality || allzero) ? true : false;
80 - // Show comment box only for quality revs or depreciated ones
81 - var commentbox = document.getElementById('mw-commentbox');
82 - if( commentbox ) {
83 - commentbox.style.display = showComment ? 'inline' : 'none';
84 - }
8579 // Show note box only for quality revs
8680 var notebox = document.getElementById('mw-notebox');
8781 if( notebox ) {
@@ -89,12 +83,6 @@
9084 // If only a few levels are zero, don't show submit link
9185 var submit = document.getElementById('submitreview');
9286 submit.disabled = ( somezero && !allzero ) ? 'disabled' : '';
93 - var comment = document.getElementById('wpReason');
94 - // Clear comment box data if not shown
95 - if( comment ) {
96 - comment.disabled = ( somezero && !allzero ) ? 'disabled' : '';
97 - comment.value = showComment ? comment.value : '';
98 - }
9987 // Clear note box data if not shown
10088 var notes = document.getElementById('wpNotes');
10189 if( notes ) {

Status & tagging log