r44013 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r44012‎ | r44013 | r44014 >
Date:13:01, 28 November 2008
Author:siebrand
Status:ok
Tags:
Comment:
(bug 16481) Special:Statistics does not explain what * means
* change asterisk to a tooltip image
* image is a 10px rendition of public domain image http://commons.wikimedia.org/wiki/Image:Bulbgraph.svg by RubySS
Modified paths:
  • /trunk/phase3/includes/specials/SpecialStatistics.php (modified) (history)
  • /trunk/phase3/skins/common/images/tooltip_icon.png (added) (history)

Diff [purge]

Index: trunk/phase3/skins/common/images/tooltip_icon.png
Cannot display: file marked as a binary type.
svn:mime-type = image/png
Property changes on: trunk/phase3/skins/common/images/tooltip_icon.png
___________________________________________________________________
Added: svn:mime-type
11 + image/png
Index: trunk/phase3/includes/specials/SpecialStatistics.php
@@ -183,8 +183,11 @@
184184 * @return string table row in HTML format
185185 */
186186 function formatRow( $text, $number, $trExtraParams = '', $tooltip = '' ) {
 187+ global $wgStylePath;
 188+
187189 if( $tooltip ) {
188 - $text = '<div title="' . wfMsg( $tooltip ) . '">' . $text . '<sup>*</sup></div>';
 190+ $tooltipText = wfMsg( $tooltip );
 191+ $text = '<div class="mw-tooltip-icon" title="' . $tooltipText . '">' . $text . '<sup><a class="mw-tooptip-icon" title="' . $tooltipText . '"><img alt="' . $tooltipText . '" src="' . $wgStylePath . '/common/images/tooltip_icon.png" width="10" height="12" border="0" /></a></sup></div>';
189192 }
190193
191194 return "<tr{$trExtraParams}>

Status & tagging log