r43993 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r43992‎ | r43993 | r43994 >
Date:12:22, 27 November 2008
Author:ialex
Status:deferred
Tags:
Comment:
Also call User::getGroupName() for values of $wgAddGroups, $wgRemoveGroups, $wgGroupsAddToSelf and $wgGroupsRemoveFromSelf
Modified paths:
  • /trunk/extensions/Configure/Configure.page.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Configure/Configure.page.php
——@@ -1060,9 +1060,10 @@
10611061 else
10621062 $checked = in_array( $right, $levs );
10631063 $id = Sanitizer::escapeId( 'wp' . $conf . '-' . $group . '-' . $right );
1064 - $desc = ( $type == 'group-bool' && is_callable( array( 'User', 'getRightDescription' ) ) ) ?
1065 - User::getRightDescription( $right ) . " (" .Xml::element( 'tt', null, $right ) . ")" :
1066 - $right;
 1064+ if( $type == 'group-bool' )
 1065+ $desc = User::getRightDescription( $right ) . " (" .Xml::element( 'tt', null, $right ) . ")";
 1066+ else
 1067+ $desc = User::getGroupName( $right );
10671068 $row .= '<li>' . Xml::check( $id, $checked, $attr + array( 'id' => $id ) ) . '&nbsp;' . Xml::tags( 'label', array( 'for' => $id ), $desc ) . "</li>\n";
10681069 }
10691070 $row .= '</ul></div>';

Status & tagging log