r43973 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r43972‎ | r43973 | r43974 >
Date:04:11, 26 November 2008
Author:werdna
Status:ok
Tags:
Comment:
Configure extension updates:
* Move some stuff around.
* Add some  s here and there.
* Fix massive screen taking-over by paring down size of textboxen found in tables.
* Redo some setting names.
Modified paths:
  • /trunk/extensions/Configure/CHANGELOG (modified) (history)
  • /trunk/extensions/Configure/Configure.i18n.php (modified) (history)
  • /trunk/extensions/Configure/Configure.js (modified) (history)
  • /trunk/extensions/Configure/Configure.page.php (modified) (history)
  • /trunk/extensions/Configure/Configure.settings-core.php (modified) (history)
  • /trunk/extensions/Configure/Configure.settings.i18n.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Configure/Configure.page.php
@@ -295,7 +295,7 @@
296296 if ( !$this->mRequireWebConf )
297297 return true;
298298
299 - global $wgConf, $wgOut, $wgRequest;
 299+ global $wgConf, $wgOut, $wgRequest, $wgLang;
300300
301301 if ( $version = $wgRequest->getVal( 'version' ) ) {
302302 $versions = $wgConf->listArchiveVersions();
@@ -315,7 +315,7 @@
316316 $this->conf[$name] += $current[$name];
317317 }
318318 }
319 - $wgOut->addWikiMsg( 'configure-edit-old' );
 319+ $wgOut->addWikiMsg( 'configure-edit-old', $wgLang->timeAndDate( $version ) );
320320 } else {
321321 $wgOut->addWikiText( '<div class="errorbox">$1</div>',
322322 array( 'configure-old-not-available', $version ) );
@@ -913,12 +913,12 @@
914914 $text .= '<tr><td>';
915915 $text .= Xml::element( 'input', array(
916916 'name' => 'wp' . $conf . "-key-0",
917 - 'type' => 'text', 'value' => '', 'size' => 45,
 917+ 'type' => 'text', 'value' => '', 'size' => 20,
918918 ) ) . "<br/>\n";
919919 $text .= '</td><td>';
920920 $text .= Xml::element( 'input', array(
921921 'name' => 'wp' . $conf . "-val-0",
922 - 'type' => 'text', 'value' => '', 'size' => 45,
 922+ 'type' => 'text', 'value' => '', 'size' => 20,
923923 ) ) . "<br/>\n";
924924 $text .= '</td></tr>';
925925 } else {
@@ -987,7 +987,7 @@
988988 $text .= '<tr><td>' . $name . '</td><td>';
989989 if ( $allowed )
990990 $text .= Xml::element( 'input', array(
991 - 'size' => 45,
 991+ 'size' => 20,
992992 'name' => "wp{$conf}-ns{$ns}",
993993 'type' => 'text', 'value' => isset( $default[$ns] ) ? $default[$ns] : ''
994994 ) ) . "\n";
Index: trunk/extensions/Configure/Configure.settings.i18n.php
@@ -99,7 +99,7 @@
100100 'configure-setting-wgExtraLanguageNames-key' => "Language code",
101101 'configure-setting-wgExtraLanguageNames-value' => "Name",
102102 'configure-setting-wgExtraRandompageSQL' => "Filter for Special:Random (in a WHERE clause)",
103 - 'configure-setting-wgExtraSubtitle' => "The subtitle of a page appears under every page title",
 103+ 'configure-setting-wgExtraSubtitle' => "Subtitle (appears under every page title)",
104104 'configure-setting-wgHideInterlanguageLinks' => "Hide interlanguage links from the sidebar",
105105 'configure-setting-wgLegalTitleChars' => "Characters permitted in page titles (regex character class)",
106106 'configure-setting-wgMaxArticleSize' => "Maximum page size (kB)",
Index: trunk/extensions/Configure/CHANGELOG
@@ -7,6 +7,7 @@
88 * Introduced explicit whitelisting of settings, rather than blacklisting
99 of other settings.
1010 * Some usability cleanup.
 11+ * Fixed javascript bug with 'Delete this entry' buttons in previous version.
1112
1213 0.10.7 - 25 November 2008
1314 * Added diff links for the versions at the top of Special:Configure and
Index: trunk/extensions/Configure/Configure.i18n.php
@@ -33,7 +33,7 @@
3434 'configure-db-table-error' => 'The database you specified does not have the required tables. Please apply configure.sql in that database.',
3535 'configure-directory-not-writable' => 'The directory used to store the settings, <tt>$1</tt>, is not writable.
3636 Please make it writable by PHP to use this extension.',
37 - 'configure-edit-old' => "'''Warning''': you are editing an <strong>old</strong> version of the configuration.",
 37+ 'configure-edit-old' => "'''Warning''': you are editing an <strong>old</strong> version of the configuration (as at $1).",
3838 'configure-compare' => "Below are the changes between the revisions as at $1 and $2",
3939 'configure-error' => 'The configuration could not be saved',
4040 'configure-js-add' => 'Add a new entry',
Index: trunk/extensions/Configure/Configure.js
@@ -167,6 +167,7 @@
168168 button.value = wgConfigureGetImageUrl;
169169 button.onclick = createImageUrlCallback( textbox );
170170
 171+ textbox.parentNode.appendChild( document.createTextNode( '\u00A0' ) );
171172 textbox.parentNode.appendChild( button );
172173 }
173174
Index: trunk/extensions/Configure/Configure.settings-core.php
@@ -12,12 +12,52 @@
1313 * http://www.mediawiki.org/wiki/Manual:Configuration_settings
1414 */
1515 $settings = array(
16 - 'popular' => array(
17 - 'general' => array(
 16+ 'site' => array(
 17+ 'site' => array(
1818 'wgSitename' => 'text',
19 - 'wgVersion' => 'text',
2019 'wgLogo' => 'image-url',
 20+ 'wgArticleRobotPolicies' => 'array',
 21+ 'wgBreakFrames' => 'bool',
 22+ 'wgCapitalLinks' => 'bool',
 23+ 'wgDefaultLanguageVariant' => 'text',
 24+ 'wgDefaultRobotPolicy' => 'text',
 25+ 'wgExemptFromUserRobotsControl' => 'array',
 26+ 'wgExtraLanguageNames' => 'array',
 27+ 'wgExtraRandompageSQL' => 'text',
 28+ 'wgExtraSubtitle' => 'text',
 29+ 'wgHideInterlanguageLinks' => 'bool',
 30+ 'wgLegalTitleChars' => 'text',
 31+ 'wgMaxArticleSize' => 'int',
 32+ 'wgMetadataWhitelist' => 'text',
 33+ 'wgNoFollowLinks' => 'bool',
 34+ 'wgPageShowWatchingUsers' => 'bool',
 35+ 'wgRestrictionLevels' => 'array',
 36+ 'wgSiteNotice' => 'text',
 37+ 'wgSiteSupportPage' => 'text',
 38+ 'wgStyleVersion' => 'int',
 39+ 'wgUniversalEditButton' => 'bool',
 40+ 'wgUrlProtocols' => 'array',
 41+ 'wgUseExternalEditor' => 'bool',
 42+ 'wgUseMetadataEdit' => 'bool',
2143 ),
 44+ 'ajax' => array(
 45+ 'wgUseAjax' => 'bool',
 46+ 'wgAjaxExportList' => 'array',
 47+ 'wgAjaxSearch' => 'bool',
 48+ 'wgAjaxUploadDestCheck' => 'bool',
 49+ 'wgAjaxWatch' => 'bool',
 50+ 'wgLivePreview' => 'bool',
 51+ ),
 52+ 'css-js' => array(
 53+ 'wgAllowUserCss' => 'bool',
 54+ 'wgAllowUserJs' => 'bool',
 55+ 'wgUseSiteCss' => 'bool',
 56+ 'wgUseSiteJs' => 'bool',
 57+ 'wgHandheldStyle' => 'text',
 58+ 'wgHandheldForIPhone' => 'bool',
 59+ ),
 60+ ),
 61+ 'namespaces' => array(
2262 'namespaces' => array(
2363 'wgContentNamespaces' => 'array',
2464 'wgExtraNamespaces' => 'array',
@@ -33,6 +73,8 @@
3474 'wgNonincludableNamespaces' => 'array',
3575 'wgSitemapNamespaces' => 'array',
3676 ),
 77+ ),
 78+ 'groups' => array(
3779 'groups' => array(
3880 'wgAutopromote' => 'array',
3981 'wgGroupPermissions' => 'array',
@@ -207,49 +249,6 @@
208250 'wgUDPProfilerPort' => 'int',
209251 ),
210252 ),
211 - 'site' => array(
212 - 'site' => array(
213 - 'wgArticleRobotPolicies' => 'array',
214 - 'wgBreakFrames' => 'bool',
215 - 'wgCapitalLinks' => 'bool',
216 - 'wgDefaultLanguageVariant' => 'text',
217 - 'wgDefaultRobotPolicy' => 'text',
218 - 'wgExemptFromUserRobotsControl' => 'array',
219 - 'wgExtraLanguageNames' => 'array',
220 - 'wgExtraRandompageSQL' => 'text',
221 - 'wgExtraSubtitle' => 'text',
222 - 'wgHideInterlanguageLinks' => 'bool',
223 - 'wgLegalTitleChars' => 'text',
224 - 'wgMaxArticleSize' => 'int',
225 - 'wgMetadataWhitelist' => 'text',
226 - 'wgNoFollowLinks' => 'bool',
227 - 'wgPageShowWatchingUsers' => 'bool',
228 - 'wgRestrictionLevels' => 'array',
229 - 'wgSiteNotice' => 'text',
230 - 'wgSiteSupportPage' => 'text',
231 - 'wgStyleVersion' => 'int',
232 - 'wgUniversalEditButton' => 'bool',
233 - 'wgUrlProtocols' => 'array',
234 - 'wgUseExternalEditor' => 'bool',
235 - 'wgUseMetadataEdit' => 'bool',
236 - ),
237 - 'ajax' => array(
238 - 'wgUseAjax' => 'bool',
239 - 'wgAjaxExportList' => 'array',
240 - 'wgAjaxSearch' => 'bool',
241 - 'wgAjaxUploadDestCheck' => 'bool',
242 - 'wgAjaxWatch' => 'bool',
243 - 'wgLivePreview' => 'bool',
244 - ),
245 - 'css-js' => array(
246 - 'wgAllowUserCss' => 'bool',
247 - 'wgAllowUserJs' => 'bool',
248 - 'wgUseSiteCss' => 'bool',
249 - 'wgUseSiteJs' => 'bool',
250 - 'wgHandheldStyle' => 'text',
251 - 'wgHandheldForIPhone' => 'bool',
252 - ),
253 - ),
254253 'stats' => array(
255254 'stats' => array(
256255 'wgCountCategorizedImagesAsUsed' => 'bool',

Status & tagging log