r43766 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r43765‎ | r43766 | r43767 >
Date:18:07, 20 November 2008
Author:ialex
Status:deferred
Tags:
Comment:
fixed some E_STRICT
Modified paths:
  • /trunk/extensions/SemanticMediaWiki/includes/articlepages/SMW_OrderedListPage.php (modified) (history)
  • /trunk/extensions/SemanticMediaWiki/specials/AskSpecial/SMW_SpecialAsk.php (modified) (history)
  • /trunk/extensions/SemanticMediaWiki/specials/SMWAdmin/SMW_SpecialSMWAdmin.php (modified) (history)
  • /trunk/extensions/SemanticMediaWiki/specials/SearchTriple/SMW_SpecialBrowse.php (modified) (history)
  • /trunk/extensions/SemanticMediaWiki/specials/SearchTriple/SMW_SpecialPageProperty.php (modified) (history)
  • /trunk/extensions/SemanticMediaWiki/specials/SearchTriple/SMW_SpecialSearchByProperty.php (modified) (history)
  • /trunk/extensions/SemanticMediaWiki/specials/URIResolver/SMW_SpecialURIResolver.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticMediaWiki/specials/AskSpecial/SMW_SpecialAsk.php
@@ -29,7 +29,7 @@
3030 wfLoadExtensionMessages('SemanticMediaWiki');
3131 }
3232
33 - function execute($p = '') {
 33+ function execute( $p ) {
3434 global $wgOut, $wgRequest, $smwgQEnabled, $smwgRSSEnabled;
3535 wfProfileIn('doSpecialAsk (SMW)');
3636 if ( ($wgRequest->getVal( 'query' ) != '') ) { // old processing
Index: trunk/extensions/SemanticMediaWiki/specials/SMWAdmin/SMW_SpecialSMWAdmin.php
@@ -31,14 +31,14 @@
3232 wfLoadExtensionMessages('SemanticMediaWiki');
3333 }
3434
35 - public function execute($par = null) {
 35+ public function execute( $par ) {
3636 global $wgOut, $wgRequest, $smwgAdminRefreshStore;
3737 global $wgServer; // "http://www.yourserver.org"
3838 // (should be equal to 'http://'.$_SERVER['SERVER_NAME'])
3939 global $wgScript; // "/subdirectory/of/wiki/index.php"
4040 global $wgUser;
4141
42 - if ( ! $wgUser->isAllowed('delete') ) {
 42+ if ( !$wgUser->isAllowed( 'delete' ) ) {
4343 $wgOut->permissionRequired('delete');
4444 return;
4545 }
Index: trunk/extensions/SemanticMediaWiki/specials/URIResolver/SMW_SpecialURIResolver.php
@@ -25,7 +25,7 @@
2626 wfLoadExtensionMessages('SemanticMediaWiki');
2727 }
2828
29 - function execute($query = '') {
 29+ function execute( $query ) {
3030 global $wgOut, $smwgIP;
3131 wfProfileIn('SpecialURIResolver::execute (SMW)');
3232 if ('' == $query) {
Index: trunk/extensions/SemanticMediaWiki/specials/SearchTriple/SMW_SpecialSearchByProperty.php
@@ -57,7 +57,7 @@
5858 *
5959 * @param[in] $query string Given by MediaWiki
6060 */
61 - public function execute($query = '') {
 61+ public function execute( $query ) {
6262 global $wgRequest, $wgOut;
6363 $this->setHeaders();
6464
Index: trunk/extensions/SemanticMediaWiki/specials/SearchTriple/SMW_SpecialBrowse.php
@@ -52,7 +52,7 @@
5353 *
5454 * @param[in] $query string Given by MediaWiki
5555 */
56 - public function execute($query = '') {
 56+ public function execute( $query ) {
5757 global $wgRequest, $wgOut;
5858 $this->setHeaders();
5959 // get the GET parameters
Index: trunk/extensions/SemanticMediaWiki/specials/SearchTriple/SMW_SpecialPageProperty.php
@@ -29,7 +29,7 @@
3030 wfLoadExtensionMessages('SemanticMediaWiki');
3131 }
3232
33 - public function execute($query = '') {
 33+ public function execute( $query ) {
3434 global $wgRequest, $wgOut, $wgUser;
3535
3636 $skin = $wgUser->getSkin();
Index: trunk/extensions/SemanticMediaWiki/includes/articlepages/SMW_OrderedListPage.php
@@ -104,7 +104,7 @@
105105 */
106106 protected function getNavigationLinks($query = array()) {
107107 global $wgUser, $wgLang;
108 - $sk =& $this->getSkin();
 108+ $sk = $this->getSkin();
109109 $limitText = $wgLang->formatNum( $this->limit );
110110
111111 $ac = count($this->articles);

Status & tagging log