r43671 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r43670‎ | r43671 | r43672 >
Date:12:29, 18 November 2008
Author:jojo
Status:ok (Comments)
Tags:
Comment:
fix: startSession() clears session, so check if we do not have a session before calling it
Modified paths:
  • /trunk/extensions/Collection/Collection.body.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Collection/Collection.body.php
@@ -214,7 +214,9 @@
215215 global $wgScriptPath;
216216 global $wgOut;
217217
218 - self::startSession();
 218+ if ( !self::hasSession() ) {
 219+ self::startSession();
 220+ }
219221
220222 $this->setHeaders();
221223 $wgOut->addInlineScript( "var wgCollectionVersion = \"$wgCollectionVersion\";" );

Comments

#Comment by Brion VIBBER (talk | contribs)   19:53, 18 November 2008

yay regression fixes

Status & tagging log