r43645 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r43644‎ | r43645 | r43646 >
Date:22:09, 17 November 2008
Author:brion
Status:ok
Tags:
Comment:
Reverting r43642 "Added $wgLoginAutocomplete to let wiki owner disable password autocompletion in Special:Userlogin by setting it to false. Defaults to true."
There's not a compelling reason to make it hard for users to manage their own password affairs here.
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/DefaultSettings.php (modified) (history)
  • /trunk/phase3/includes/specials/SpecialUserlogin.php (modified) (history)
  • /trunk/phase3/includes/templates/Userlogin.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/DefaultSettings.php
@@ -484,12 +484,6 @@
485485 $wgPasswordSender = 'MediaWiki Mail <apache@' . $wgServerName . '>';
486486
487487 /**
488 - * Determines if password autocompletion should be enabled in Special:Userlogin
489 - * Defaults to true. If false, autocomplete="off" will be injected in the form tag.
490 - */
491 -$wgLoginAutocomplete = true;
492 -
493 -/**
494488 * dummy address which should be accepted during mail send action
495489 * It might be necessay to adapt the address or to set it equal
496490 * to the $wgEmergencyContact address
Index: trunk/phase3/includes/specials/SpecialUserlogin.php
@@ -791,7 +791,6 @@
792792 global $wgUser, $wgOut, $wgAllowRealName, $wgEnableEmail;
793793 global $wgCookiePrefix, $wgAuth, $wgLoginLanguageSelector;
794794 global $wgAuth, $wgEmailConfirmToEdit, $wgCookieExpiration;
795 - global $wgLoginAutocomplete;
796795
797796 $titleObj = SpecialPage::getTitleFor( 'Userlogin' );
798797
@@ -871,8 +870,7 @@
872871 $template->set( 'canreset', $wgAuth->allowPasswordChange() );
873872 $template->set( 'canremember', ( $wgCookieExpiration > 0 ) );
874873 $template->set( 'remember', $wgUser->getOption( 'rememberpassword' ) or $this->mRemember );
875 - $template->set( 'autocomplete', $wgLoginAutocomplete );
876 -
 874+
877875 # Prepare language selection links as needed
878876 if( $wgLoginLanguageSelector ) {
879877 $template->set( 'languages', $this->makeLanguageSelector() );
Index: trunk/phase3/includes/templates/Userlogin.php
@@ -25,7 +25,7 @@
2626
2727 <div id="loginstart"><?php $this->msgWiki( 'loginstart' ); ?></div>
2828 <div id="userloginForm">
29 -<form name="userlogin" method="post" action="<?php $this->text('action') ?>" <?PHP if( !$this->data['autocomplete'] ) echo 'autocomplete="off"'; ?>>
 29+<form name="userlogin" method="post" action="<?php $this->text('action') ?>">
3030 <h2><?php $this->msg('login') ?></h2>
3131 <p id="userloginlink"><?php $this->html('link') ?></p>
3232 <?php $this->html('header'); /* pre-table point for form plugins... */ ?>
Index: trunk/phase3/RELEASE-NOTES
@@ -63,8 +63,6 @@
6464 * Image namespace and accompanying talk namespace renamed to File. For backward
6565 compatibility purposes, Image still works. External tools may need to be
6666 updated.
67 -* Added $wgLoginAutocomplete to let wiki owner disable password autocompletion
68 - in Special:Userlogin by setting it to false. Defaults to true.
6967
7068 === Migrated extensions ===
7169 The following extensions are migrated into MediaWiki 1.14:

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r43642Added $wgLoginAutocomplete to let wiki owner disable password autocompletion ...harddisk21:49, 17 November 2008

Status & tagging log