r43563 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r43562‎ | r43563 | r43564 >
Date:22:00, 15 November 2008
Author:aaron
Status:deferred
Tags:
Comment:
* Rename class to shorter name
* Make two pages unlisted
Modified paths:
  • /trunk/extensions/LiquidThreads/LiquidThreads.php (modified) (history)
  • /trunk/extensions/LiquidThreads/LqtPages.php (modified) (history)

Diff [purge]

Index: trunk/extensions/LiquidThreads/LiquidThreads.php
@@ -47,7 +47,7 @@
4848 $wgHooks['SkinTemplateOutputPageBeforeExec'][] = 'LqtDispatch::setNewtalkHTML';
4949
5050 $wgSpecialPages['DeleteThread'] = 'SpecialDeleteThread';
51 -$wgSpecialPages['MoveThread'] = 'SpecialMoveThreadToAnotherPage';
 51+$wgSpecialPages['MoveThread'] = 'SpecialMoveThread';
5252 $wgSpecialPages['NewMessages'] = 'SpecialNewMessages';
5353
5454 // Obtained with $ grep -ir 'class .*' *.php | perl -n -e 'if (/(\w+\.php):\s*class (\w+)/) {print "\$wgAutoloadClasses['\''$2'\''] = \$dir.'\''$1'\'';\n";}'
@@ -72,7 +72,7 @@
7373 $wgAutoloadClasses['ThreadHistoryListingView'] = $dir.'LqtPages.php';
7474 $wgAutoloadClasses['ThreadHistoricalRevisionView'] = $dir.'LqtPages.php';
7575 $wgAutoloadClasses['SummaryPageView'] = $dir.'LqtPages.php';
76 -$wgAutoloadClasses['SpecialMoveThreadToAnotherPage'] = $dir.'LqtPages.php';
 76+$wgAutoloadClasses['SpecialMoveThread'] = $dir.'LqtPages.php';
7777 $wgAutoloadClasses['SpecialDeleteThread'] = $dir.'LqtPages.php';
7878 $wgAutoloadClasses['NewUserMessagesView'] = $dir.'LqtPages.php';
7979 $wgAutoloadClasses['SpecialNewMessages'] = $dir.'LqtPages.php';
Index: trunk/extensions/LiquidThreads/LqtPages.php
@@ -849,11 +849,11 @@
850850 }
851851
852852
853 -class SpecialMoveThreadToAnotherPage extends SpecialPage {
 853+class SpecialMoveThread extends UnlistedSpecialPage {
854854 private $user, $output, $request, $title, $thread;
855855
856856 function __construct() {
857 - SpecialPage::SpecialPage( 'Movethread' );
 857+ parent::__construct( 'Movethread' );
858858 $this->includable( false );
859859 }
860860
@@ -973,11 +973,11 @@
974974 }
975975 }
976976
977 -class SpecialDeleteThread extends SpecialPage {
 977+class SpecialDeleteThread extends UnlistedSpecialPage {
978978 private $user, $output, $request, $title, $thread;
979979
980980 function __construct() {
981 - SpecialPage::SpecialPage( 'Deletethread' );
 981+ parent::__construct( 'Deletethread' );
982982 $this->includable( false );
983983 }
984984

Status & tagging log