r43559 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r43558‎ | r43559 | r43560 >
Date:16:21, 15 November 2008
Author:ialex
Status:ok
Tags:
Comment:
Only show the link to mw.org on setting's name because when you have a link in the description ($wgCountCategorizedImagesAsUsed, $wgSortSpecialPages, ...) then the page becomes invalid for the W3C validator
Modified paths:
  • /trunk/extensions/Configure/Configure.page.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Configure/Configure.page.php
@@ -1024,18 +1024,18 @@
10251025 $attribs['valign'] = 'top';
10261026 $msgVal = wfMsgExt( $msg, array( 'parseinline' ) );
10271027 $rawVal = Xml::element( 'tt', null, "\$$conf" );
1028 - if ( wfEmptyMsg( $msg, $msgVal ) )
1029 - $msgVal = $rawVal;
1030 - else
1031 - $msgVal = "$msgVal ($rawVal)";
10321028 if ( $showLink ) {
10331029 $url = 'http://www.mediawiki.org/wiki/Manual:$' . $conf;
1034 - $link = Xml::tags( 'a', array( 'href' => $url, 'class' => 'configure-doc' ), $msgVal );
 1030+ $link = Xml::tags( 'a', array( 'href' => $url, 'class' => 'configure-doc' ), $rawVal );
10351031 } else {
1036 - $link = $msgVal;
 1032+ $link = $rawVal;
10371033 }
 1034+ if ( wfEmptyMsg( $msg, $msgVal ) )
 1035+ $msgVal = $link;
 1036+ else
 1037+ $msgVal = "$msgVal ($link)";
10381038 $attribs['class'] = 'configure-left-column';
1039 - $td1 = Xml::openElement( 'td', $attribs ) . $link . '</td>';
 1039+ $td1 = Xml::openElement( 'td', $attribs ) . $msgVal . '</td>';
10401040 $attribs['class'] = 'configure-right-column';
10411041 if ( $this->isSettingAvailable( $conf ) )
10421042 $td2 = Xml::openElement( 'td', $attribs ) . $this->buildInput( $conf, $params ) . '</td>';

Status & tagging log