r43489 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r43488‎ | r43489 | r43490 >
Date:11:33, 14 November 2008
Author:jojo
Status:ok
Tags:
Comment:
use <input />, not <input></input>
Modified paths:
  • /trunk/extensions/Collection/Collection.templates.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Collection/Collection.templates.php
@@ -78,7 +78,7 @@
7979 $writer = array_rand($this->data['formats']);
8080 $buttonLabel = wfMsgHtml('coll-download_as', htmlspecialchars($this->data['formats'][$writer]));
8181 ?>
82 - <input type="hidden" name="writer" value="<?php echo htmlspecialchars($writer) ?>"></input>
 82+ <input type="hidden" name="writer" value="<?php echo htmlspecialchars($writer) ?>" />
8383 <?php } else {
8484 $buttonLabel = wfMsgHtml('coll-download');
8585 ?>
@@ -98,15 +98,15 @@
9999 <?php if ($GLOBALS['wgUser']->isLoggedIn()) { ?>
100100 <?php $this->msgWiki('coll-save_collection_text') ?>
101101 <form id="saveForm" action="<?php echo htmlspecialchars(SkinTemplate::makeSpecialUrlSubpage('Collection', 'save_collection/')) ?>" method="post">
102 - <input id="personalCollType" type="radio" name="colltype" value="personal" checked="checked"></input>
 102+ <input id="personalCollType" type="radio" name="colltype" value="personal" checked="checked" />
103103 <label for="personalCollType"><?php $this->msg('coll-personal_collection_label') ?></label>
104104 <label for="personalCollTitle"><?php echo htmlspecialchars($GLOBALS['wgUser']->getUserPage()->getPrefixedText() . '/' . wfMsgForContent('coll-collections') . '/') ?></label>
105 - <input id="personalCollTitle" type="text" name="pcollname"></input><br />
106 - <input id="communityCollType" type="radio" name="colltype" value="community"></input>
 105+ <input id="personalCollTitle" type="text" name="pcollname" /><br />
 106+ <input id="communityCollType" type="radio" name="colltype" value="community" />
107107 <label for="communityCollType"><?php $this->msg('coll-community_collection_label') ?></label>
108108 <label for="communityCollTitle"><?php echo htmlspecialchars(Title::makeTitle($GLOBALS['wgCommunityCollectionNamespace'], wfMsgForContent('coll-collections'))->getPrefixedText() . '/') ?></label>
109 - <input id="communityCollTitle" type="text" name="ccollname" disabled="disabled"></input><br />
110 - <input id="saveButton" type="submit" value="<?php $this->msg('coll-save_collection') ?>"<?php if (count($this->data['collection']['items']) == 0) { ?> disabled="disabled"<?php } ?>></input>
 109+ <input id="communityCollTitle" type="text" name="ccollname" disabled="disabled" /><br />
 110+ <input id="saveButton" type="submit" value="<?php $this->msg('coll-save_collection') ?>"<?php if (count($this->data['collection']['items']) == 0) { ?> disabled="disabled"<?php } ?> />
111111 </form>
112112
113113 <?php } else {
@@ -231,10 +231,10 @@
232232 <?php $this->msgWiki('coll-load_overwrite_text'); ?>
233233
234234 <form action="<?php echo htmlspecialchars(SkinTemplate::makeSpecialUrlSubpage('Collection', 'load_collection/')) ?>" method="post">
235 - <input name="overwrite" type="submit" value="<?php $this->msg('coll-overwrite') ?>"></input>
236 - <input name="append" type="submit" value="<?php $this->msg('coll-append') ?>"></input>
237 - <input name="cancel" type="submit" value="<?php $this->msg('coll-cancel') ?>"></input>
238 - <input name="colltitle" type="hidden" value="<?php echo htmlspecialchars($this->data['title']->getPrefixedText()) ?>"></input>
 235+ <input name="overwrite" type="submit" value="<?php $this->msg('coll-overwrite') ?>" />
 236+ <input name="append" type="submit" value="<?php $this->msg('coll-append') ?>" />
 237+ <input name="cancel" type="submit" value="<?php $this->msg('coll-cancel') ?>" />
 238+ <input name="colltitle" type="hidden" value="<?php echo htmlspecialchars($this->data['title']->getPrefixedText()) ?>" />
239239 </form>
240240
241241 <?php
@@ -254,9 +254,9 @@
255255 <p><?php echo $GLOBALS['wgParser']->parse(wfMsgNoTrans('coll-overwrite_text', $this->data['title']->getPrefixedText()), $GLOBALS['wgTitle'], $GLOBALS['wgOut']->parserOptions(), true)->getText() ?></p>
256256
257257 <form action="<?php echo htmlspecialchars(SkinTemplate::makeSpecialUrlSubpage('Collection', 'save_collection/')) ?>" method="post">
258 - <input name="overwrite" type="submit" value="<?php $this->msg('coll-yes') ?>"></input>
259 - <input name="abort" type="submit" value="<?php $this->msg('coll-no') ?>"></input>
260 - <input name="colltitle" type="hidden" value="<?php echo htmlspecialchars($this->data['title']->getPrefixedText()) ?>"></input>
 258+ <input name="overwrite" type="submit" value="<?php $this->msg('coll-yes') ?>" />
 259+ <input name="abort" type="submit" value="<?php $this->msg('coll-no') ?>" />
 260+ <input name="colltitle" type="hidden" value="<?php echo htmlspecialchars($this->data['title']->getPrefixedText()) ?>" />
261261 </form>
262262
263263 <?php

Status & tagging log