r43452 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r43451‎ | r43452 | r43453 >
Date:11:07, 13 November 2008
Author:jojo
Status:old
Tags:
Comment:
fix for adding/removing articles with an older revision
Modified paths:
  • /trunk/extensions/Collection/Collection.body.php (modified) (history)
  • /trunk/extensions/Collection/Collection.i18n.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Collection/Collection.i18n.php
@@ -74,7 +74,7 @@
7575 'coll-mwserve_failed_msg' => 'An error occured on the render server: <nowiki>$1</nowiki>',
7676 'coll-error_reponse' => 'Error response from server',
7777 'coll-empty_collection' => 'Empty collection',
78 - 'coll-revision' => 'Revision: %PARAM%',
 78+ 'coll-revision' => 'Revision: $1',
7979 'coll-save_collection_title' => 'Save and share your collection',
8080 'coll-save_collection_text' => 'Choose a location:',
8181 'coll-login_to_save' => 'If you want to save collections for later use, please [[Special:UserLogin|log in or create an account]].',
Index: trunk/extensions/Collection/Collection.body.php
@@ -1119,7 +1119,7 @@
11201120 $params ) );
11211121 $out .= <<<EOS
11221122 <li>
1123 - <a href="$href" onclick="collectionCall('AddArticle', [wgNamespaceNumber, wgTitle, 0]); return false;" rel="nofollow">$addArticle</a>
 1123+ <a href="$href" onclick="collectionCall('AddArticle', [wgNamespaceNumber, wgTitle, $oldid]); return false;" rel="nofollow">$addArticle</a>
11241124 </li>
11251125 EOS
11261126 ;
@@ -1130,7 +1130,7 @@
11311131 $params ) );
11321132 $out .= <<<EOS
11331133 <li>
1134 - <a href="$href" onclick="collectionCall('RemoveArticle', [wgNamespaceNumber, wgTitle, 0]); return false;" rel="nofollow">$removeArticle</a>
 1134+ <a href="$href" onclick="collectionCall('RemoveArticle', [wgNamespaceNumber, wgTitle, $oldid]); return false;" rel="nofollow">$removeArticle</a>
11351135 </li>
11361136 EOS
11371137 ;

Status & tagging log