r43426 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r43425‎ | r43426 | r43427 >
Date:23:35, 12 November 2008
Author:brion
Status:old
Tags:
Comment:
XHTML fixes
Modified paths:
  • /trunk/extensions/Collection/Collection.body.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Collection/Collection.body.php
@@ -211,9 +211,9 @@
212212
213213 $this->setHeaders();
214214 $wgOut->addInlineScript( "var wgCollectionVersion = \"$wgCollectionVersion\";" );
215 - $wgOut->addScript( "<script type=\"$wgJsMimeType\" src=\"$wgScriptPath/extensions/Collection/collection/jquery.js?$wgStyleVersion&$wgCollectionVersion\"></script>" );
216 - $wgOut->addScript( "<script type=\"$wgJsMimeType\" src=\"$wgScriptPath/extensions/Collection/collection/jquery.ui.js?$wgStyleVersion&$wgCollectionVersion\"></script>" );
217 - $wgOut->addScript( "<script type=\"$wgJsMimeType\" src=\"$wgScriptPath/extensions/Collection/collection/collection.js?$wgStyleVersion&$wgCollectionVersion\"></script>" );
 215+ $wgOut->addScript( "<script type=\"$wgJsMimeType\" src=\"$wgScriptPath/extensions/Collection/collection/jquery.js?$wgStyleVersion&amp;$wgCollectionVersion\"></script>" );
 216+ $wgOut->addScript( "<script type=\"$wgJsMimeType\" src=\"$wgScriptPath/extensions/Collection/collection/jquery.ui.js?$wgStyleVersion&amp;$wgCollectionVersion\"></script>" );
 217+ $wgOut->addScript( "<script type=\"$wgJsMimeType\" src=\"$wgScriptPath/extensions/Collection/collection/collection.js?$wgStyleVersion&amp;$wgCollectionVersion\"></script>" );
218218
219219 $template = new CollectionPageTemplate();
220220 $template->set( 'collection', $_SESSION['wsCollection'] );
@@ -765,8 +765,8 @@
766766 $wgOut->addInlineScript( 'var writer = "' . urlencode( $response['writer']) . '";' );
767767 $wgOut->addInlineScript( 'var collection_rendering = true;' );
768768 $wgOut->addInlineScript( "var wgCollectionVersion = \"$wgCollectionVersion\";" );
769 - $wgOut->addScript( "<script type=\"$wgJsMimeType\" src=\"$wgScriptPath/extensions/Collection/collection/jquery.js?$wgStyleVersion&$wgCollectionVersion\"></script>" );
770 - $wgOut->addScript( "<script type=\"$wgJsMimeType\" src=\"$wgScriptPath/extensions/Collection/collection/collection.js?$wgStyleVersion&$wgCollectionVersion\"></script>" );
 769+ $wgOut->addScript( "<script type=\"$wgJsMimeType\" src=\"$wgScriptPath/extensions/Collection/collection/jquery.js?$wgStyleVersion&amp;$wgCollectionVersion\"></script>" );
 770+ $wgOut->addScript( "<script type=\"$wgJsMimeType\" src=\"$wgScriptPath/extensions/Collection/collection/collection.js?$wgStyleVersion&amp;$wgCollectionVersion\"></script>" );
771771 $wgOut->setPageTitle( wfMsg( 'coll-rendering_title' ) );
772772
773773 if ( isset($response['status']['status'] ) && $response['status']['status'] ) {
@@ -1153,7 +1153,7 @@
11541154 $msg = htmlspecialchars( wfMsg( 'coll-clear_collection_confirm' ) );
11551155 $out .= <<<EOS
11561156 <li>
1157 - <a href=\"$href\" onclick="if (confirm('$msg')) collectionCall('Clear', []); return false;" rel=\"nofollow\">$clearCollection</a>
 1157+ <a href="$href" onclick="if (confirm('$msg')) collectionCall('Clear', []); return false;" rel="nofollow">$clearCollection</a>
11581158 </li>
11591159 EOS
11601160 ;
@@ -1167,6 +1167,7 @@
11681168 ;
11691169 }
11701170
 1171+ $out .= "</ul>";
11711172 return $out;
11721173 }
11731174

Status & tagging log