r43401 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r43400‎ | r43401 | r43402 >
Date:00:40, 12 November 2008
Author:simetrical
Status:old
Tags:
Comment:
Fix for 43393: use normal MW id convention

id's and classes should start with "mw-" and delimit words with
hyphens.
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/templates/Userlogin.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/templates/Userlogin.php
@@ -54,7 +54,7 @@
5555 $doms .= "<option>" . htmlspecialchars( $dom ) . "</option>";
5656 }
5757 ?>
58 - <tr id="userDomainSection">
 58+ <tr id="mw-user-domain-section">
5959 <td class="mw-label"><?php $this->msg( 'yourdomainname' ) ?></td>
6060 <td class="mw-input">
6161 <select name="wpDomain" value="<?php $this->text( 'domain' ) ?>"
Index: trunk/phase3/RELEASE-NOTES
@@ -202,7 +202,8 @@
203203 * (bug 15835) Added Content-Style-Type meta tag
204204 * Add class="disambiguationpage" to <body> tag for disambiguations
205205 * (bug 11027) Add parameter to MW:Randompage-nopages so that user can see the namespace.
206 -* Add id="userDomainSection" to <tr> tag in Userlogin.php template so that admins with a single domain can hide the domain section using CSS
 206+* Add id="mw-user-domain-section" to <tr> tag in Userlogin.php template so that
 207+ admins with a single domain can hide the domain section using CSS
207208
208209 === Bug fixes in 1.14 ===
209210

Status & tagging log