r43387 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r43386‎ | r43387 | r43388 >
Date:17:16, 11 November 2008
Author:laner
Status:old
Tags:
Comment:
* Had the version check logic for which hook I use for auto authentication wrong.
Modified paths:
  • /trunk/extensions/LdapAuthentication/LdapAuthentication.php (modified) (history)

Diff [purge]

Index: trunk/extensions/LdapAuthentication/LdapAuthentication.php
@@ -1785,9 +1785,9 @@
17861786 if( $wgLDAPAutoAuthUsername != null ) {
17871787 $wgAuth->printDebug( "wgLDAPAutoAuthUsername is not null, adding hooks.", NONSENSITIVE );
17881788 if ( version_compare( $wgVersion, '1.14.0', '<' ) ) {
 1789+ $wgHooks['UserLoadFromSession'][] = 'LdapAutoAuthentication::Authenticate';
 1790+ } else {
17891791 $wgHooks['UserLoadAfterLoadFromSession'][] = 'LdapAutoAuthentication::Authenticate';
1790 - } else {
1791 - $wgHooks['UserLoadFromSession'][] = 'LdapAutoAuthentication::Authenticate';
17921792 }
17931793 $wgHooks['PersonalUrls'][] = 'LdapAutoAuthentication::NoLogout'; /* Disallow logout link */
17941794 }

Status & tagging log