r43350 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r43349‎ | r43350 | r43351 >
Date:14:07, 10 November 2008
Author:jojo
Status:old
Tags:
Comment:
use different icons. make show-link an icon. remoevd unused css classes from template.
Modified paths:
  • /trunk/extensions/Collection/Collection.templates.php (modified) (history)
  • /trunk/extensions/Collection/collection/bottom.png (deleted) (history)
  • /trunk/extensions/Collection/collection/cross.png (deleted) (history)
  • /trunk/extensions/Collection/collection/down.png (modified) (history)
  • /trunk/extensions/Collection/collection/remove.png (added) (history)
  • /trunk/extensions/Collection/collection/show.png (added) (history)
  • /trunk/extensions/Collection/collection/top.png (deleted) (history)
  • /trunk/extensions/Collection/collection/up.png (modified) (history)

Diff [purge]

Index: trunk/extensions/Collection/collection/top.png
Cannot display: file marked as a binary type.
svn:mime-type = image/png
Index: trunk/extensions/Collection/collection/bottom.png
Cannot display: file marked as a binary type.
svn:mime-type = image/png
Index: trunk/extensions/Collection/collection/cross.png
Cannot display: file marked as a binary type.
svn:mime-type = image/png
Index: trunk/extensions/Collection/collection/remove.png
Cannot display: file marked as a binary type.
svn:mime-type = application/octet-stream
Property changes on: trunk/extensions/Collection/collection/remove.png
___________________________________________________________________
Added: svn:mime-type
11 + application/octet-stream
Index: trunk/extensions/Collection/collection/show.png
Cannot display: file marked as a binary type.
svn:mime-type = application/octet-stream
Property changes on: trunk/extensions/Collection/collection/show.png
___________________________________________________________________
Added: svn:mime-type
22 + application/octet-stream
Index: trunk/extensions/Collection/collection/up.png
Cannot display: file marked as a binary type.
svn:mime-type = image/png
Index: trunk/extensions/Collection/collection/down.png
Cannot display: file marked as a binary type.
svn:mime-type = image/png
Index: trunk/extensions/Collection/Collection.templates.php
@@ -159,19 +159,20 @@
160160 foreach($this->data['collection']['items'] as $index => $item) {
161161 if ($item['type'] == 'article') { ?>
162162 <li id="item-<?php echo $index ?>" class="article">
163 - <a class="removeLink" onclick="return coll_remove_item(<?php echo $index ?>)" href="<?php echo htmlspecialchars(SkinTemplate::makeSpecialUrlSubpage('Collection', 'remove_item/', 'index=' . $index)) ?>" title="<?php $this->msg('coll-remove') ?>"><img src="<?php echo htmlspecialchars($mediapath . "cross.png") ?>" width="11" height="11" alt="<?php $this->msg('remove') ?>" /></a>
 163+ <a onclick="return coll_remove_item(<?php echo $index ?>)" href="<?php echo htmlspecialchars(SkinTemplate::makeSpecialUrlSubpage('Collection', 'remove_item/', 'index=' . $index)) ?>" title="<?php $this->msg('coll-remove') ?>"><img src="<?php echo htmlspecialchars($mediapath . "remove.png") ?>" width="10" height="10" alt="<?php $this->msg('remove') ?>" /></a>
164164 <noscript>
165165 <?php if ($index == 0) { ?>
166 - <img class="moveUpDisabled" src="<?php echo htmlspecialchars($mediapath . "trans.png") ?>" width="11" height="11" alt="" />
 166+ <img src="<?php echo htmlspecialchars($mediapath . "trans.png") ?>" width="10" height="10" alt="" />
167167 <?php } else { ?>
168 - <a class="moveUpLink" onclick="return coll_move_item(<?php echo $index . ', -1' ?>)" href="<?php echo htmlspecialchars(SkinTemplate::makeSpecialUrlSubpage('Collection', 'move_item/', 'delta=-1&index=' . $index)) ?>" title="<?php $this->msg('coll-move_up') ?>"><img src="<?php echo htmlspecialchars($mediapath . "up.png") ?>" width="11" height="11" alt="<?php $this->msg('coll-move_up') ?>" /></a>
 168+ <a onclick="return coll_move_item(<?php echo $index . ', -1' ?>)" href="<?php echo htmlspecialchars(SkinTemplate::makeSpecialUrlSubpage('Collection', 'move_item/', 'delta=-1&index=' . $index)) ?>" title="<?php $this->msg('coll-move_up') ?>"><img src="<?php echo htmlspecialchars($mediapath . "up.png") ?>" width="10" height="10" alt="<?php $this->msg('coll-move_up') ?>" /></a>
169169 <?php }
170170 if ($index == count($this->data['collection']['items']) - 1) { ?>
171 - <img class="moveDownDisabled" src="<?php echo htmlspecialchars($mediapath . "trans.png") ?>" width="11" height="11" alt="" />
 171+ <img src="<?php echo htmlspecialchars($mediapath . "trans.png") ?>" width="10" height="10" alt="" />
172172 <?php } else { ?>
173 - <a class="moveDownLink" onclick="return coll_move_item(<?php echo $index . ', 1' ?>)" href="<?php echo htmlspecialchars(SkinTemplate::makeSpecialUrlSubpage('Collection', 'move_item/', 'delta=1&index=' . $index)) ?>" title="<?php $this->msg('coll-move_down') ?>"><img src="<?php echo htmlspecialchars($mediapath . "down.png") ?>" width="11" height="11" alt="<?php $this->msg('coll-move_down') ?>" /></a>
 173+ <a onclick="return coll_move_item(<?php echo $index . ', 1' ?>)" href="<?php echo htmlspecialchars(SkinTemplate::makeSpecialUrlSubpage('Collection', 'move_item/', 'delta=1&index=' . $index)) ?>" title="<?php $this->msg('coll-move_down') ?>"><img src="<?php echo htmlspecialchars($mediapath . "down.png") ?>" width="10" height="10" alt="<?php $this->msg('coll-move_down') ?>" /></a>
174174 <?php } ?>
175175 </noscript>
 176+ <a href="<?php echo $url ?>" title="<?php $this->msg('coll-show') ?>"><img src="<?php echo htmlspecialchars($mediapath . "show.png") ?>" width="10" height="10" alt="<?php $this->msg('coll-show') ?>" /></a>
176177 <?php if ($item['revision'] && $item['revision'] != $item['latest']) {
177178 $revision = '('. htmlspecialchars(wfMsg('coll-revision', $item['revision'])) . ')';
178179 $url = $item['url'] . '?oldid=' . $item['revision'];
@@ -188,23 +189,23 @@
189190 }
190191 echo ' ' . $revision; ?>
191192 </span>
192 - <a class="articleLink" href="<?php echo $url ?>" style="margin-left:1em;">[<?php $this->msg('coll-show') ?>]</a>
193193 </li>
194194 <?php } else if ($item['type'] == 'chapter') { ?>
195195 <li id="item-<?php echo $index ?>" class="chapter" style="margin-top:0.3em;">
196 - <a class="removeLink" onclick="return coll_remove_item(<?php echo $index ?>)" href="<?php echo htmlspecialchars(SkinTemplate::makeSpecialUrlSubpage('Collection', 'remove_item/', 'index=' . $index)) ?>" title="<?php $this->msg('coll-remove') ?>"><img src="<?php echo htmlspecialchars($mediapath . "cross.png") ?>" width="11" height="11" alt="<?php $this->msg('coll-remove') ?>" /></a>
 196+ <a onclick="return coll_remove_item(<?php echo $index ?>)" href="<?php echo htmlspecialchars(SkinTemplate::makeSpecialUrlSubpage('Collection', 'remove_item/', 'index=' . $index)) ?>" title="<?php $this->msg('coll-remove') ?>"><img src="<?php echo htmlspecialchars($mediapath . "remove.png") ?>" width="10" height="10" alt="<?php $this->msg('coll-remove') ?>" /></a>
197197 <noscript>
198198 <?php if ($index == 0) { ?>
199 - <img class="moveUpDisabled" src="<?php echo htmlspecialchars($mediapath . "trans.png") ?>" width="11" height="11" alt="" />
 199+ <img src="<?php echo htmlspecialchars($mediapath . "trans.png") ?>" width="10" height="10" alt="" />
200200 <?php } else { ?>
201 - <a class="moveUpLink" onclick="return coll_move_item(<?php echo $index . ', -1' ?>)" href="<?php echo htmlspecialchars(SkinTemplate::makeSpecialUrlSubpage('Collection', 'move_item/', 'delta=-1&index=' . $index)) ?>" title="<?php $this->msg('coll-move_up') ?>"><img src="<?php echo htmlspecialchars($mediapath . "up.png") ?>" width="11" height="11" alt="<?php $this->msg('coll-move_up') ?>" /></a>
 201+ <a onclick="return coll_move_item(<?php echo $index . ', -1' ?>)" href="<?php echo htmlspecialchars(SkinTemplate::makeSpecialUrlSubpage('Collection', 'move_item/', 'delta=-1&index=' . $index)) ?>" title="<?php $this->msg('coll-move_up') ?>"><img src="<?php echo htmlspecialchars($mediapath . "up.png") ?>" width="10" height="10" alt="<?php $this->msg('coll-move_up') ?>" /></a>
202202 <?php }
203203 if ($index == count($this->data['collection']['items']) - 1) { ?>
204 - <img class="moveDownDisabled" src="<?php echo htmlspecialchars($mediapath . "trans.png") ?>" width="11" height="11" alt="" />
 204+ <img src="<?php echo htmlspecialchars($mediapath . "trans.png") ?>" width="10" height="10" alt="" />
205205 <?php } else { ?>
206 - <a class="moveDownLink" onclick="return coll_move_item(<?php echo $index . ', 1' ?>)" href="<?php echo htmlspecialchars(SkinTemplate::makeSpecialUrlSubpage('Collection', 'move_item/', 'delta=1&index=' . $index)) ?>" title="<?php $this->msg('coll-move_down') ?>"><img src="<?php echo htmlspecialchars($mediapath . "down.png") ?>" width="11" height="11" alt="<?php $this->msg('coll-move_down') ?>" /></a>
 206+ <a onclick="return coll_move_item(<?php echo $index . ', 1' ?>)" href="<?php echo htmlspecialchars(SkinTemplate::makeSpecialUrlSubpage('Collection', 'move_item/', 'delta=1&index=' . $index)) ?>" title="<?php $this->msg('coll-move_down') ?>"><img src="<?php echo htmlspecialchars($mediapath . "down.png") ?>" width="10" height="10" alt="<?php $this->msg('coll-move_down') ?>" /></a>
207207 <?php } ?>
208208 </noscript>
 209+ <img src="<?php echo htmlspecialchars($mediapath . "trans.png") ?>" width="10" height="10" alt="" />
209210 <strong class="chapterTitle" style="margin-left: 0.2em;"><?php echo htmlspecialchars($item['title']) ?></strong>
210211 <a class="makeVisible" <?php if (!isset($this->data['is_ajax'])) { echo 'style="display:none"'; } ?> onclick="return coll_rename_chapter(<?php echo $index . ', \'' . $item['title'] . '\''; ?>)" href="javascript:void(0)">[<?php $this->msg('coll-rename') ?>]</a>
211212 </li>

Status & tagging log