r43338 MediaWiki - Code Review archive

Repository:	MediaWiki
Revision:	< r43337‎ \| r43338 \| r43339 >
Date:	02:54, 10 November 2008
Author:	werdna
Status:	old
Tags:
Comment:	Note why that code is ==, not !=. It confused me for a few minutes.
Modified paths:	/branches/on_wiki_configuration/includes/RightsManager.php (modified) (history)

Diff [purge]

Index: branches/on_wiki_configuration/includes/RightsManager.php
—	—	@@ -685,6 +685,7 @@
686	686	$toDelete = array();
687	687	$toSet = array();
688	688	foreach( $rights as $right => $status ) {
	689	+ ## If they already have the right from config, no point putting it in the DB.
689	690	if ($this->rightInConfig( $group, $right ) == $status) {
690	691	$toDelete[] = $right;
691	692	} else {

15:36, 12 September 2011 Meno25 (talk | contribs) changed the status of r43338 [removed: ok added: old]