r43268 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r43267‎ | r43268 | r43269 >
Date:22:09, 6 November 2008
Author:siebrand
Status:old
Tags:
Comment:
Update on r43103. Add the 'norollbackdiff' toggle to 'misc', not to 'edit' per suggestion by Aaron.
Modified paths:
  • /trunk/phase3/includes/specials/SpecialPreferences.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialPreferences.php
@@ -1004,9 +1004,6 @@
10051005 'forceeditsummary',
10061006 ) ) );
10071007
1008 - if( $wgUser->isAllowed( 'rollback' ) )
1009 - $wgOut->addHtml( $this->getToggle( 'norollbackdiff' ) );
1010 -
10111008 $wgOut->addHtml( '</fieldset>' );
10121009
10131010 # Recent changes
@@ -1118,9 +1115,13 @@
11191116
11201117 foreach ( $togs as $tname ) {
11211118 if( !array_key_exists( $tname, $this->mUsedToggles ) ) {
1122 - $wgOut->addHTML( $this->getToggle( $tname ) );
 1119+ if( $tname == 'norollbackdiff' && $wgUser->isAllowed( 'rollback' ) )
 1120+ $wgOut->addHTML( $this->getToggle( $tname ) );
 1121+ else
 1122+ $wgOut->addHTML( $this->getToggle( $tname ) );
11231123 }
11241124 }
 1125+
11251126 $wgOut->addHTML( '</fieldset>' );
11261127
11271128 wfRunHooks( 'RenderPreferencesForm', array( $this, $wgOut ) );

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r43103(bug 15761) Add user toggle to omit diff after rollback. Patch by FunPika.siebrand23:44, 2 November 2008

Status & tagging log