r43112 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r43111‎ | r43112 | r43113 >
Date:08:08, 3 November 2008
Author:vyznev
Status:old
Tags:
Comment:
oops, r43111 was incomplete, here's the rest of it :-/
Modified paths:
  • /trunk/phase3/includes/specials/SpecialPreferences.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialPreferences.php
@@ -42,7 +42,7 @@
4343 $this->mStubs = $request->getVal( 'wpStubs' );
4444 $this->mRows = $request->getVal( 'wpRows' );
4545 $this->mCols = $request->getVal( 'wpCols' );
46 - $this->mSkin = $request->getVal( 'wpSkin' );
 46+ $this->mSkin = Skin::normalizeKey( $request->getVal( 'wpSkin' ) );
4747 $this->mMath = $request->getVal( 'wpMath' );
4848 $this->mDate = $request->getVal( 'wpDate' );
4949 $this->mUserEmail = $request->getVal( 'wpUserEmail' );
@@ -268,7 +268,10 @@
269269 $wgUser->setOption( 'variant', $this->mUserVariant );
270270 $wgUser->setOption( 'nickname', $this->mNick );
271271 $wgUser->setOption( 'quickbar', $this->mQuickbar );
272 - $wgUser->setOption( 'skin', $this->mSkin );
 272+ global $wgAllowUserSkin;
 273+ if( $wgAllowUserSkin ) {
 274+ $wgUser->setOption( 'skin', $this->mSkin );
 275+ }
273276 global $wgUseTeX;
274277 if( $wgUseTeX ) {
275278 $wgUser->setOption( 'math', $this->mMath );

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r43111Hide skin tab in preferences entirely is $wgAllowUserSkin is false, remove th...vyznev07:56, 3 November 2008

Status & tagging log