r43109 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r43108‎ | r43109 | r43110 >
Date:02:01, 3 November 2008
Author:brion
Status:old
Tags:
Comment:
Fix for compatibility with CentralNotice: 'dismiss' button now hides just the local sitenotice, not the whole <div>, since that's the only part that will be gone on next page view
Modified paths:
  • /trunk/extensions/DismissableSiteNotice/DismissableSiteNotice.php (modified) (history)

Diff [purge]

Index: trunk/extensions/DismissableSiteNotice/DismissableSiteNotice.php
——@@ -60,7 +60,7 @@
6161 var date = new Date();
6262 date.setTime(date.getTime() + 30*86400*1000);
6363 document.cookie = cookieName + siteNoticeID + "; expires="+date.toGMTString() + "; path=/";
64 - var element = document.getElementById('siteNotice');
 64+ var element = document.getElementById('mw-dismissable-notice');
6565 element.parentNode.removeChild(element);
6666 }
6767 document.writeln('<table width="100%" id="mw-dismissable-notice"><tr><td width="80%">'+siteNoticeValue+'</td>');

Status & tagging log