r43092 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r43091‎ | r43092 | r43093 >
Date:20:59, 2 November 2008
Author:ashley
Status:old
Tags:
Comment:
applying r2851 from Wikia codebase: "MW-escape social profile links. (At least one of them.)"
Modified paths:
  • /trunk/extensions/SocialProfile/UserProfile/UserProfilePage.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SocialProfile/UserProfile/UserProfilePage.php
@@ -418,7 +418,7 @@
419419 $similar_fans = Title::makeTitle(NS_SPECIAL, "SimilarFans");
420420 $update_profile = Title::makeTitle(NS_SPECIAL, "UpdateProfile");
421421 $watchlist = Title::makeTitle(NS_SPECIAL, "Watchlist");
422 - $contributions = Title::makeTitle(NS_SPECIAL, "Contributions");
 422+ $contributions = SpecialPage::getTitleFor('Contributions', $user);
423423 $send_message = Title::makeTitle(NS_SPECIAL, "UserBoard");
424424 $upload_avatar = Title::makeTitle(NS_SPECIAL, "UploadAvatar");
425425 $user_page = Title::makeTitle(NS_USER, $user);
@@ -480,7 +480,7 @@
481481 $output .= "<a href=\"".$give_gift->escapeFullURL('user='.$user_safe)."\" rel=\"nofollow\">".wfMsg('user-send-gift')."</a> |";
482482 }
483483
484 - $output .= "<a href=\"".$contributions->escapeFullURL()."/{$user_safe}\" rel=\"nofollow\">".wfMsg('user-contributions')."</a> ";
 484+ $output .= "<a href=\"".$contributions->escapeFullURL()."\" rel=\"nofollow\">".wfMsg('user-contributions')."</a> ";
485485
486486 //Links to User:user_name from User_profile:
487487 if( $wgTitle->getNamespace() == NS_USER_PROFILE && $this->profile_data["user_id"] && $this->profile_data["user_page_type"] == 0){

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r2851new monochrome skingabrielwicke23:03, 26 March 2004

Status & tagging log