r43031 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r43030‎ | r43031 | r43032 >
Date:21:41, 1 November 2008
Author:siebrand
Status:old
Tags:
Comment:
* Fix a bug in Authors extension ($ missing)
* Comment out Authors extension. Method creditlink() appears to be missing.

Fatal error: Call to undefined function creditlink() in D:\mediawiki\phase3\extensions\uniwiki\Authors\Authors.php on line 83
Modified paths:
  • /trunk/extensions/uniwiki/Authors/Authors.php (modified) (history)
  • /trunk/extensions/uniwiki/UniwikiSettings.php (modified) (history)

Diff [purge]

Index: trunk/extensions/uniwiki/Authors/Authors.php
@@ -13,7 +13,7 @@
1414 $wgExtensionCredits['other'][] = array(
1515 'name' => 'Authors',
1616 'author' => 'Merrick Schaefer, Mark Johnston, Evan Wheeler and Adam Mckaig (at UNICEF)',
17 - 'description' => 'Appends a list of contributors to articles'
 17+ 'description' => 'Appends a list of contributors to articles',
1818 'url' => 'http://www.mediawiki.org/wiki/Extension:Uniwiki/Authors',
1919 'svn-date' => '$LastChangedDate$',
2020 'svn-revision' => '$LastChangedRevision$',
@@ -29,7 +29,7 @@
3030
3131 /* do nothing if the option is disabled
3232 * (but why would the extension be enabled?) */
33 - if ( !wgShowAuthors )
 33+ if ( !$wgShowAuthors )
3434 return true;
3535
3636 // only build authors on namespaces in $wgShowAuthorsNamespaces
Index: trunk/extensions/uniwiki/UniwikiSettings.php
@@ -10,7 +10,8 @@
1111 require_once("$uw/GenericEditPage/GenericEditPage.php");
1212 require_once("$uw/CatBoxAtTop/CatBoxAtTop.php");
1313 require_once("$uw/Layouts/Layouts.php");
14 -require_once("$uw/Authors/Authors.php");
 14+# Broken. creditLink() missing.
 15+#require_once("$uw/Authors/Authors.php");
1516 require_once("$uw/CustomToolbar/CustomToolbar.php");
1617 require_once("$uw/CreatePage/CreatePage.php");
1718 require_once("$uw/FormatChanges/FormatChanges.php");

Status & tagging log