r42926 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r42925‎ | r42926 | r42927 >
Date:17:49, 31 October 2008
Author:grondin
Status:old
Tags:
Comment:
Fixing broken code after r42804: Revision::getTimestampFromId
Applying patch proposed by PaulC in bug #16205
Modified paths:
  • /trunk/extensions/FlaggedRevs/FlaggedRevs.hooks.php (modified) (history)

Diff [purge]

Index: trunk/extensions/FlaggedRevs/FlaggedRevs.hooks.php
@@ -657,7 +657,7 @@
658658 $prevRevId = self::getPreviousRevisionId( $rev );
659659 # Get the revision ID the incoming one was based off...
660660 if( !$baseRevId && $prevRevId ) {
661 - $prevTimestamp = Revision::getTimestampFromId( $prevRevId, $rev->getPage() ); // use PK
 661+ $prevTimestamp = Revision::getTimestampFromId( $title, $prevRevId ); // use PK
662662 # Get edit timestamp. Existance already valided by EditPage.php. If
663663 # not present, then it shouldn't be, like null edits.
664664 $editTimestamp = $wgRequest->getVal('wpEdittime');

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r42804Make getTimestampFromId() need a title. Avoids some secondary lookups and orp...aaron10:04, 30 October 2008

Status & tagging log