r42711 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r42710‎ | r42711 | r42712 >
Date:02:38, 28 October 2008
Author:mrzman
Status:old
Tags:
Comment:
partial revert of r42695, don't trim the comment
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/RecentChange.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/RecentChange.php
@@ -645,19 +645,6 @@
646646 # no colour (\003) switches back to the term default
647647 $fullString = "\00314[[\00307$title\00314]]\0034 $flag\00310 " .
648648 "\00302$url\003 \0035*\003 \00303$user\003 \0035*\003 $szdiff \00310$comment\003\n";
649 - # RFC 2812 sets the limit for IRC message length at 512 bytes
650 - # If the message is longer than that, trim the comment as much as necessary
651 - # It might still be too long, but there's not much else we can trim without losing anything important
652 - if ( strlen($fullString) > 512 ) {
653 - $extra = strlen($fullString) - 512;
654 - if ( strlen($comment) > $extra ) {
655 - $comment = substr($comment, 0, strlen($comment) - $extra);
656 - } else {
657 - $comment = '';
658 - }
659 - $fullString = "\00314[[\00307$title\00314]]\0034 $flag\00310 " .
660 - "\00302$url\003 \0035*\003 \00303$user\003 \0035*\003 $szdiff \00310$comment\003\n";
661 - }
662649
663650 return $fullString;
664651 }
Index: trunk/phase3/RELEASE-NOTES
@@ -287,8 +287,7 @@
288288 * (bug 12764) Special:LonelyPages shows transcluded pages
289289 * (bug 16073) Enhanced RecentChanges uses onclick handler with better fallback if
290290 JavaScript is disabled.
291 -* (bug 4253) Recentchanges IRC messages no longer include title in diff URLs and
292 - the comment is trimmed if necessary to maintain proper message length.
 291+* (bug 4253) Recentchanges IRC messages no longer include title in diff URLs
293292 * Allow '0' to be an accesskey.
294293
295294 === API changes in 1.14 ===

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r42695(bug 4253) - recentchanges IRC:...mrzman22:41, 27 October 2008

Status & tagging log