r42648 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r42647‎ | r42648 | r42649 >
Date:10:15, 27 October 2008
Author:guyvdb
Status:old
Tags:
Comment:
Fixed bug in HTML differ. A bad index was used when everything is removed from a page.
Modified paths:
  • /trunk/phase3/includes/diff/HTMLDiff.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/diff/HTMLDiff.php
@@ -323,7 +323,7 @@
324324 } else {
325325 $prevResult = new LastCommonParentResult();
326326 $prevResult->parent = $this->bodyNode;
327 - $prevResult->indexInLastCommonParent = 0;
 327+ $prevResult->indexInLastCommonParent = -1;
328328 }
329329 if (isset($nextleaf)) {
330330 $nextResult = $nextLeaf->getLastCommonParent($deletedNodes[count($deletedNodes) - 1]);

Status & tagging log