r42538 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r42537‎ | r42538 | r42539 >
Date:09:07, 25 October 2008
Author:aaron
Status:old
Tags:
Comment:
(bug 16104) Follow up to r42502; check here too
Modified paths:
  • /trunk/extensions/FlaggedRevs/FlaggedRevs.hooks.php (modified) (history)

Diff [purge]

Index: trunk/extensions/FlaggedRevs/FlaggedRevs.hooks.php
@@ -504,7 +504,7 @@
505505 $ig->mParser->mOutput->fr_ImageSHA1Keys[$nt->getDBkey()][$time] = $sha1;
506506 # Bug 15748, be lax about commons image sync status
507507 $file = $file ? $file : self::getLocalFile( $nt, $time ); # FIXME: would be nice not to double fetch!
508 - if( $file->exists() && $file->isLocal() && $time > $ig->mParser->mOutput->fr_newestImageTime ) {
 508+ if( $file && $file->exists() && $file->isLocal() && $time > $ig->mParser->mOutput->fr_newestImageTime ) {
509509 $ig->mParser->mOutput->fr_newestImageTime = $time;
510510 }
511511 return true;

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r42502Don't error out if !$fileaaron21:10, 24 October 2008

Status & tagging log