r42515 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r42514‎ | r42515 | r42516 >
Date:23:18, 24 October 2008
Author:skizzerz
Status:old
Tags:
Comment:
* fix for bug 16098: specify add-self and remove-self group in the return array for changeableGroups() so that SpecialUserrights.php does not complain about non-array parameters when editing oneself
Modified paths:
  • /trunk/extensions/CentralAuth/SpecialGlobalGroupMembership.php (modified) (history)

Diff [purge]

Index: trunk/extensions/CentralAuth/SpecialGlobalGroupMembership.php
@@ -58,7 +58,8 @@
5959
6060 ## Permission MUST be gained from global rights.
6161 if ( $this->mGlobalUser->hasGlobalPermission( 'globalgroupmembership' ) ) {
62 - return array( 'add' => $allGroups, 'remove' => $allGroups);
 62+ #specify addself and removeself as empty arrays -- bug 16098
 63+ return array( 'add' => $allGroups, 'remove' => $allGroups, 'add-self' => array(), 'remove-self' => array() );
6364 } else {
6465 return array();
6566 }

Status & tagging log