r42431 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r42430‎ | r42431 | r42432 >
Date:23:26, 23 October 2008
Author:brion
Status:old
Tags:
Comment:
Revert r42264 "(bug 15806) Added html ids to certain tags. Patch by Pathoschild."
Weird ids that don't follow coding standards and just seem kind of odd
Modified paths:
  • /trunk/extensions/CentralAuth/SpecialCentralAuth.php (modified) (history)

Diff [purge]

Index: trunk/extensions/CentralAuth/SpecialCentralAuth.php
@@ -247,7 +247,7 @@
248248 'hidden' => $globalUser->isHidden() ? wfMsg( 'centralauth-admin-yes' ) : wfMsg( 'centralauth-admin-no' ) );
249249 $out = '<ul>';
250250 foreach( $attribs as $tag => $data ) {
251 - $out .= Xml::element( 'li', array( 'id'=>"info_$tag" ), wfMsg( "centralauth-admin-info-$tag" ) . ' ' . $data );
 251+ $out .= Xml::element( 'li', array(), wfMsg( "centralauth-admin-info-$tag" ) . ' ' . $data );
252252 }
253253 $out .= '</ul>';
254254 $wgOut->addHtml( $out );
@@ -273,7 +273,7 @@
274274
275275 function listRemainder( $list ) {
276276 ksort( $list );
277 - $s = '<ul id="list_unattached">';
 277+ $s = '<ul>';
278278 foreach ( $list as $row ) {
279279 $s .= '<li>' . $this->foreignUserLink( $row['wiki'] ) . "</li>\n";
280280 }
@@ -288,8 +288,7 @@
289289 Xml::openElement( 'form',
290290 array(
291291 'method' => 'post',
292 - 'action' => $this->getTitle( $this->mUserName )->getLocalUrl( 'action=submit' ),
293 - 'id' => 'form_merged' ) ) .
 292+ 'action' => $this->getTitle( $this->mUserName )->getLocalUrl( 'action=submit' ) ) ) .
294293 Xml::hidden( 'wpMethod', $action ) .
295294 Xml::hidden( 'wpEditToken', $wgUser->editToken() ) .
296295 '<table>' .
@@ -360,8 +359,7 @@
361360 Xml::element( 'h2', array(), wfMsg( "centralauth-admin-{$action}-title" ) ) .
362361 Xml::openElement( 'form', array(
363362 'method' => 'POST',
364 - 'action' => $this->getTitle()->getFullUrl( 'target=' . urlencode( $this->mUserName ) ),
365 - 'id' => "form_$action" ) ) .
 363+ 'action' => $this->getTitle()->getFullUrl( 'target=' . urlencode( $this->mUserName ) ) ) ) .
366364 Xml::hidden( 'wpMethod', $action ) .
367365 Xml::hidden( 'wpEditToken', $wgUser->editToken() ) .
368366 wfMsgExt( "centralauth-admin-{$action}-description", 'parse' ) .

Follow-up revisions

RevisionCommit summaryAuthorDate
r42665(bug 15806) Add html IDs to tags. This time let's follow naming standards and...demon18:27, 27 October 2008

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r42264(bug 15806) Added html ids to certain tags. Patch by Pathoschild.btongminh14:21, 20 October 2008

Status & tagging log