r42235 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r42234‎ | r42235 | r42236 >
Date:23:53, 19 October 2008
Author:brion
Status:old
Tags:
Comment:
Back out r42181 "(bug 6179) Actually the log for people who can't edit"

There's no link to the full log; the last entry may not always be very clear. It's also pretty long and technical, filled with crap like:

23:49, 19 October 2008 WikiSysop (Talk | contribs) changed protection level for "Main Page" [edit=autoconfirmed] (indefinite) [move=autoconfirmed] (indefinite) ‎ (hist)

It would probably be more user-friendly to show the comment describing the purpose of the protection... which of course might not have anything to do with the last log entry (which might be "changing expiration date" or something).

Backing out for now...
Modified paths:
  • /trunk/phase3/includes/OutputPage.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/OutputPage.php
——@@ -1259,14 +1259,7 @@
12601260 } else {
12611261 $this->setPageTitle( wfMsg( 'badaccess' ) );
12621262 }
1263 - if( $protected ) {
1264 - $this->addHTML( "<div class='mw-warning-with-logexcerpt'>\n" );
1265 - }
12661263 $this->addWikiText( $this->formatPermissionsErrorMessage( $reasons, $action ) );
1267 - if( $protected ) {
1268 - LogEventsList::showLogExtract( $this, 'protect', $wgTitle->getPrefixedText(), '', 1 );
1269 - $this->addHTML( "</div>\n" );
1270 - }
12711264 } else {
12721265 // Wiki is read only
12731266 $this->setPageTitle( wfMsg( 'readonly' ) );

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r40509Add more protection info on edit (bug 6179)aaron22:46, 5 September 2008
r42181(bug 6179) Actually the log for people who can't editaaron23:25, 17 October 2008

Status & tagging log