r42227 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r42226‎ | r42227 | r42228 >
Date:18:29, 19 October 2008
Author:river
Status:old
Tags:
Comment:
Makefile: some "cc" don't like "-o /dev/null"
util.c: fix #ifdef
Modified paths:
  • /trunk/tools/trickle/Makefile (modified) (history)
  • /trunk/tools/trickle/util.c (modified) (history)

Diff [purge]

Index: trunk/tools/trickle/Makefile
@@ -12,20 +12,20 @@
1313 rm -f trickle trickle.o tar.o util.o rdcp.o proto.o ldflags $(CFGHDRS)
1414 t_sysparam.h:
1515 echo "#include <sys/param.h>" >test.c
16 - -($(CC) -c -o /dev/null test.c && echo "#define T_SYS_PARAM_H 1") >t_sysparam.h
17 - rm -f test.c
 16+ -($(CC) -c -o _conftest test.c && echo "#define T_SYS_PARAM_H 1") >t_sysparam.h
 17+ rm -f test.c _conftest
1818 t_stdint.h:
1919 echo "#include <stdint.h>" >test.c
20 - -($(CC) -c -o /dev/null test.c && echo "#define T_STDINT 1") >t_stdint.h
21 - rm -f test.c
 20+ -($(CC) -c -o _conftest test.c && echo "#define T_STDINT 1") >t_stdint.h
 21+ rm -f test.c _conftest
2222 t_xti.h:
2323 echo "#include <xti.h>" >test.c
24 - -($(CC) -c -o /dev/null test.c && echo "#define T_XTI 1") >t_xti.h
25 - rm -f test.c
 24+ -($(CC) -c -o _conftest test.c && echo "#define T_XTI 1") >t_xti.h
 25+ rm -f test.c _conftest
2626 t_alloca.h:
2727 echo "#include <alloca.h>" >test.c
28 - -($(CC) -c -o /dev/null test.c && echo "#define T_ALLOCA 1") >t_alloca.h
29 - rm -f test.c
 28+ -($(CC) -c -o _conftest test.c && echo "#define T_ALLOCA 1") >t_alloca.h
 29+ rm -f test.c _conftest
3030 ldflags:
3131 echo "int main() { return 0; }" > test.c
3232 -($(CC) test.c -lsocket -lnsl -o _conftest && echo -lsocket -lnsl) >ldflags
Index: trunk/tools/trickle/util.c
@@ -78,7 +78,7 @@
7979 fprintf(stderr, "%s: %s (%s)\n", e, strerror(errno), c);
8080 }
8181
82 -#if defined(__sun) && !defined(__svr4)
 82+#if defined(__sun) && !defined(__svr4__)
8383 extern int sys_nerr;
8484 extern char *sys_errlist[];
8585

Status & tagging log