r42181 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r42180‎ | r42181 | r42182 >
Date:23:25, 17 October 2008
Author:aaron
Status:old (Comments)
Tags:
Comment:
(bug 6179) Actually the log for people who can't edit
Modified paths:
  • /trunk/phase3/includes/OutputPage.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/OutputPage.php
——@@ -1259,7 +1259,14 @@
12601260 } else {
12611261 $this->setPageTitle( wfMsg( 'badaccess' ) );
12621262 }
 1263+ if( $protected ) {
 1264+ $this->addHTML( "<div class='mw-warning-with-logexcerpt'>\n" );
 1265+ }
12631266 $this->addWikiText( $this->formatPermissionsErrorMessage( $reasons, $action ) );
 1267+ if( $protected ) {
 1268+ LogEventsList::showLogExtract( $this, 'protect', $wgTitle->getPrefixedText(), '', 1 );
 1269+ $this->addHTML( "</div>\n" );
 1270+ }
12641271 } else {
12651272 // Wiki is read only
12661273 $this->setPageTitle( wfMsg( 'readonly' ) );

Follow-up revisions

RevisionCommit summaryAuthorDate
r42235Back out r42181 "(bug 6179) Actually the log for people who can't edit"...brion23:53, 19 October 2008

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r40509Add more protection info on edit (bug 6179)aaron22:46, 5 September 2008

Comments

#Comment by Voice of All (talk | contribs)   04:11, 18 October 2008

Code structure does look a bit funky :D

#Comment by Brion VIBBER (talk | contribs)   23:52, 19 October 2008

There's no link to the full log; the last entry may not always be very clear. It's also pretty long and technical, filled with crap like:

23:49, 19 October 2008 WikiSysop (Talk | contribs) changed protection level for "Main Page" [edit=autoconfirmed] (indefinite) [move=autoconfirmed] (indefinite) ‎ (hist)

It would probably be more user-friendly to show the comment describing the purpose of the protection... which of course might not have anything to do with the last log entry (which might be "changing expiration date" or something).

Backing out for now...

#Comment by Brion VIBBER (talk | contribs)   23:54, 19 October 2008

Reverted for now in r42235

Status & tagging log