r42131 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r42130‎ | r42131 | r42132 >
Date:02:16, 16 October 2008
Author:aaron
Status:old
Tags:
Comment:
(bug 16001) Don't make broken links
Modified paths:
  • /trunk/extensions/CodeReview/CodeRevisionView.php (modified) (history)

Diff [purge]

Index: trunk/extensions/CodeReview/CodeRevisionView.php
@@ -154,8 +154,12 @@
155155 $rev = $this->mRev->getId();
156156 $prev = $rev - 1;
157157 $safePath = wfUrlEncode( $path );
158 - $link = $this->mSkin->makeExternalLink( "$viewvc$safePath?view=markup&pathrev=$rev", $encPath );
159 - if( $action !== 'A' ) {
 158+ if( $action !== 'D' ) {
 159+ $link = $this->mSkin->makeExternalLink( "$viewvc$safePath?view=markup&pathrev=$rev", $encPath );
 160+ } else {
 161+ $link = $encPath;
 162+ }
 163+ if( $action !== 'A' && $action !== 'D' ) {
160164 $diff = ' (' .
161165 $this->mSkin->makeExternalLink( "$viewvc$safePath?&pathrev=$rev&r1=$prev&r2=$rev",
162166 wfMsgHtml('code-rev-diff-link') ) .

Status & tagging log