r42059 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r42058‎ | r42059 | r42060 >
Date:22:39, 13 October 2008
Author:mrzman
Status:old
Tags:
Comment:
* (bug 1250) Let users use "show preview" and "show changes" even if the wiki is set to read-only mode.
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/EditPage.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/EditPage.php
@@ -375,18 +375,10 @@
376376 return;
377377 }
378378
379 - if ( wfReadOnly() ) {
380 - if ( $this->save ){
 379+ if ( wfReadOnly() && $this->save ) {
381380 // Force preview
382381 $this->save = false;
383382 $this->preview = true;
384 - } elseif ( $this->preview || $this->diff ) {
385 - // A warning will be displayed instead
386 - } else {
387 - $this->readOnlyPage( $this->getContent() );
388 - wfProfileOut( __METHOD__ );
389 - return;
390 - }
391383 }
392384
393385 $wgOut->addScriptFile( 'edit.js' );
Index: trunk/phase3/RELEASE-NOTES
@@ -161,6 +161,8 @@
162162 marked by unhealthy obsession with edit counts).
163163 * Added a file cache to the parser to improve page rendering time on pages with
164164 several uses of the same image.
 165+* (bug 1250) Users can still use "show preview" and "show changes" even if the
 166+ wiki is set to read-only mode.
165167
166168 === Bug fixes in 1.14 ===
167169

Status & tagging log