r42045 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r42044‎ | r42045 | r42046 >
Date:19:13, 13 October 2008
Author:aaron
Status:old
Tags:
Comment:
Add debug log item for r42040
Modified paths:
  • /trunk/phase3/includes/User.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/User.php
@@ -805,6 +805,8 @@
806806 $sId = intval( $_COOKIE["{$wgCookiePrefix}UserID"] );
807807 if( isset( $_SESSION['wsUserID'] ) && $sId != $_SESSION['wsUserID'] ) {
808808 $this->loadDefaults(); // Possible collision!
 809+ wfDebugLog( 'loginSessions', "Session user ID ({$_SESSION['wsUserID']}) and
 810+ cookie user ID ($sId) don't match!" );
809811 return false;
810812 }
811813 $_SESSION['wsUserID'] = $sId;

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r42040(bug 6464) Check for session id collisions by checking cookie user ID against...aaron18:41, 13 October 2008

Status & tagging log